Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(release-please): release-please crashes with Error: could not find changelog entry corresponding to release PR #947

Closed
tmatsuo opened this issue May 17, 2021 · 1 comment · Fixed by #963
Closed

bug(release-please): release-please crashes with Error: could not find changelog entry corresponding to release PR #947

tmatsuo opened this issue May 17, 2021 · 1 comment · Fixed by #963
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented May 17, 2021

release-please crashed with the following error.

Error: could not find changelog entry corresponding to release PR
at Object.extractReleaseNotes (/workspace/node_modules/release-please/build/src/util/release-notes.js:22)
at Node.buildReleaseForVersion (/workspace/node_modules/release-please/build/src/release-pr.js:289)
at runMicrotasks (<anonymous>)
@chingor13 chingor13 self-assigned this Jun 14, 2021
@chingor13 chingor13 transferred this issue from googleapis/repo-automation-bots Jul 1, 2021
@chingor13 chingor13 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 1, 2021
@chingor13
Copy link
Contributor

Related: #940

@chingor13 chingor13 mentioned this issue Jul 12, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 12, 2021
@chingor13
fix: throw custom error class for missing release notes error (#963)
100dc14 
Throwing a typed error will allow the caller to handle appropriately (file an issue, etc).

Fixes #947
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 13, 2021
@release-please
chore: release 11.15.0 (#966)
049dd11 
🤖 I have created a release \*beep\* \*boop\*
---
## [11.15.0](https://www.github.com/googleapis/release-please/compare/v11.14.2...v11.15.0) (2021-07-13)


### Features

* **rust:** Support manifest releaser ([#954](https://www.github.com/googleapis/release-please/issues/954)) ([fed5c35](https://www.github.com/googleapis/release-please/commit/fed5c35d2cfd709b455afffcec88aa188e3753e4))


### Bug Fixes

* throw custom error class for missing release notes error ([#963](https://www.github.com/googleapis/release-please/issues/963)) ([100dc14](https://www.github.com/googleapis/release-please/commit/100dc14898167ea35b8be8a0069a3fb91fac8237)), closes [#947](https://www.github.com/googleapis/release-please/issues/947)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: throw custom error class for missing release notes error chingor13/release-please
2 participants
@chingor13 @tmatsuo