Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove beta api annotation from client header customization surface #2311

Merged
merged 6 commits into from
Feb 12, 2024
Merged

chore: remove beta api annotation from client header customization surface #2311

merged 6 commits into from
Feb 12, 2024

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Dec 18, 2023 •
edited
Loading

Fixes #2100

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 18, 2023
@diegomarquezp diegomarquezp marked this pull request as ready for review December 19, 2023 21:33
@diegomarquezp diegomarquezp requested a review from a team as a code owner December 19, 2023 21:33
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 19, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@diegomarquezp diegomarquezp merged commit 3c5284a into main Feb 12, 2024
25 checks passed
@diegomarquezp diegomarquezp deleted the remove-beta-api-header-surface branch February 12, 2024 20:56
ddixit14 pushed a commit that referenced this pull request Feb 15, 2024
@diegomarquezp @ddixit14
chore: remove beta api annotation from client header customization su…
2e50f2a 
…rface (#2311)

Fixes #2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generator: Consider removing @BetaApi from client header customization surface
3 participants
@diegomarquezp @lqiu96 @burkedavison