Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove beta httpjson #2358

Merged
merged 12 commits into from
Feb 15, 2024
Merged

chore: remove beta httpjson #2358

merged 12 commits into from
Feb 15, 2024

Conversation

JoeWang1127
Copy link
Collaborator

Fixes #2101 ☕️

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 11, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 15, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 marked this pull request as ready for review February 15, 2024 16:34
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner February 15, 2024 16:34
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2024
Copy link
Contributor

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since we're removing the BetaApi annotation from the HttpJsonServiceStub and I don't think the GrpcServiceStub has an BetaApi annotations, can you check if we still need BetaApi in the FIXED_TYPESTORE?

If neither transport needs it, I think we can remove it.

@JoeWang1127
Copy link
Collaborator Author

JoeWang1127 commented Feb 15, 2024

I think the annotation is still used in

if (!PackageChecker.isGaApi(service.pakkage())) {
annotations.add(AnnotationNode.withType(FIXED_TYPESTORE.get("BetaApi")));
}

@JoeWang1127 JoeWang1127 merged commit 7da92b1 into main Feb 15, 2024
25 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/remove-beta-httpjson branch February 15, 2024 20:40
ddixit14 pushed a commit that referenced this pull request Feb 15, 2024
lqiu96 pushed a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generator: Consider removing @BetaApi from client HTTP JSON surface
2 participants