-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove beta httpjson #2358
Conversation
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since we're removing the BetaApi annotation from the HttpJsonServiceStub and I don't think the GrpcServiceStub has an BetaApi annotations, can you check if we still need BetaApi in the FIXED_TYPESTORE?
Line 133 in 9c8c940
BetaApi.class, |
If neither transport needs it, I think we can remove it.
I think the annotation is still used in Lines 518 to 520 in b28235a
|
Fixes #2101 ☕️