-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup @BetaApi from Resource Name Builder Methods #2450
Conversation
Should this one be removed as well? Line 224 in 3b36de7
Lines 1703 to 1711 in ed21464
|
Yes. Thanks for catching this. |
I am a bit confused. I followed this guide to update golden files for showcase, and showcase ci tests are passing. Lines 121 to 136 in 14dd389
@lqiu96 I am missing anything in my workflow? Or is this class not part of showcase golden? |
I suspect that you made gapic-generator changes and need to re-run Edit: Oh, I just saw your comment about showcase CI tests passing. Can you try clearing the GH CI cache? |
Ah one more thing, can you double check if the |
@lqiu96 @burkedavison can you take another look? |
removing redundant files. context from #2450 (comment)
removing redundant files. context from #2450 (comment)
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
🤖 I have created a release *beep* *boop* --- <details><summary>2.36.0</summary> ## [2.36.0](v2.35.0...v2.36.0) (2024-02-29) ### Features * check library_name is unique among libraries ([#2490](#2490)) ([8123f0b](8123f0b)) ### Bug Fixes * cleanup @BetaApi from Resource Name Builder Methods ([#2450](#2450)) ([6e8d098](6e8d098)), closes [#2099](#2099) * Fix watchdog to start with WAITING state ([#2468](#2468)) ([dedc40f](dedc40f)) * ignore comment in BUILD ([#2492](#2492)) ([6ca20e5](6ca20e5)) * remove @BetaApi from ApiFutures and ApiService ([#2454](#2454)) ([f59e717](f59e717)), closes [#2098](#2098) ### Dependencies * grandfathering the dependencies for java-pubsublite and java-bigquery ([#2504](#2504)) ([9ceab23](9ceab23)) * update dependency gradle to v7.6.4 ([#2474](#2474)) ([607dc59](607dc59)) * update dependency org.graalvm.sdk:graal-sdk to v22.3.5 ([#2475](#2475)) ([2de487b](2de487b)) * update grpc dependencies to v1.62.2 ([#2506](#2506)) ([f438603](f438603)) ### Documentation * Add contribution guidelines. ([#2045](#2045)) ([9939b43](9939b43)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
fixes #2099