-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: recursive comparison in hermetic build IT #2542
Conversation
Hi @diegomarquezp, thanks for fixing integration test. Could you also try to fix the difference in the generated files by changing committish in configuration file? |
Thanks @JoeWang1127, this definitely went right for @JoeWang1127 @blakeli0 what if we go for fixing java-bigtable as a follow up since the purpose of this PR is to fix the testing logic? I have disabled the bigtable test for now. |
Please retry analysis of this Pull-Request directly on SonarCloud |
|
||
END_NESTED_COMMIT | ||
BEGIN_NESTED_COMMIT | ||
docs: [document-ai] updated comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added document-ai
to the test configuration because I didn't find a commit in alloydb
, alloydb-connectors
and apigee-connect
.
Since we have comments in alloydb
, should we remove this entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I'm removing document-ai
to speed the test up
LGTM. |
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
Fixes #2540
Sample error message when running
library_generation/test/integration_tests.py