Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: write description to a file #2548

Merged
merged 2 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion library_generation/generate_pr_description.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,16 @@ def generate(
repo_url: str,
baseline_commit: str,
) -> str:
return generate_pr_descriptions(
description = generate_pr_descriptions(
generation_config_yaml=generation_config_yaml,
repo_url=repo_url,
baseline_commit=baseline_commit,
)
idx = generation_config_yaml.rfind("/")
config_path = generation_config_yaml[:idx]
with open(f"{config_path}/pr_description.txt", "w+") as f:
f.write(description)
return description


def generate_pr_descriptions(
Expand Down
2 changes: 1 addition & 1 deletion library_generation/test/integration_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def __get_config_files(cls, path: str) -> List[tuple[str, str]]:
if sub_dir.is_file():
continue
repo = sub_dir.name
if repo == "golden":
if repo == "golden" or repo == "java-bigtable":
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable integration test in java-bigtable (issue)

continue
config = f"{sub_dir}/{config_name}"
config_files.append((repo, config))
Expand Down
Loading