Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shared-deps third party's parent is generator-pom-parent #2664

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Apr 18, 2024

Following Tomo's suggestion in #2602 (comment)

Shared-Dep's third_party parent is gapic-generator-java-pom-parent. threetenbp's + otel version is defined in gapic-generator-java-pom-parent

@lqiu96 lqiu96 requested a review from suztomo April 18, 2024 18:17
@lqiu96 lqiu96 requested a review from a team as a code owner April 18, 2024 18:17
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 18, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lqiu96 lqiu96 enabled auto-merge (squash) April 18, 2024 18:52
@lqiu96 lqiu96 merged commit e741371 into main Apr 18, 2024
41 of 42 checks passed
@lqiu96 lqiu96 deleted the shared-deps-parent branch April 18, 2024 19:00
@diegomarquezp
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants