Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: temporarily disable golden tests #352

Merged
merged 3 commits into from
Mar 13, 2024
Merged

build: temporarily disable golden tests #352

merged 3 commits into from
Mar 13, 2024

Conversation

dandhlee
Copy link
Collaborator

@dandhlee dandhlee commented Mar 13, 2024

Having a lot of issues with golden tests. We should likely figure out a good step going forward - it could be virtualenv that we're having issues for editable installs.

We have a critical fix that needs to be updated to use this repository without needing a bunch of workarounds. I'll get back to enabling the golden tests after I've made a new release.

Towards #344.

  • Tests pass

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 13, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Mar 13, 2024
@dandhlee dandhlee marked this pull request as ready for review March 13, 2024 03:31
@dandhlee dandhlee requested review from a team as code owners March 13, 2024 03:31
@dandhlee dandhlee merged commit 2be2b64 into main Mar 13, 2024
7 checks passed
@dandhlee dandhlee deleted the disable_tests branch March 13, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants