-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add retry test inject failure midway in gRPC ReadObject #533
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
=======================================
Coverage 98.68% 98.69%
=======================================
Files 50 50
Lines 7898 7956 +58
=======================================
+ Hits 7794 7852 +58
Misses 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One high level question about the approach; let me know what you think.
As discussed offline, I updated Retry Test API Forced Failures Support description by transport and clarified how retry instructions result in the gRPC context. @tritone PTAL, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; thanks for the updates.
@coryan Wanted to check with you for future planning if there is any need to support This PR adds support to the Retry Test API. Planning to merge today if no issues, thanks! |
No, and we can always add the support if it becomes needed. |
Add Retry Test API support for injecting failure midway in gRPC ReadObject
Update README
Enable methods that have Retry Test support in gRPC
Tests pass
Appropriate changes to README are included in PR