-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pipx #545
feat: support pipx #545
Conversation
Sadly our builds are broken at HEAD, even though the last commit in https://github.com/googleapis/storage-testbench/actions/runs/6356186515 I have asked help from people with more Python expertise than me. /FYI: @pitrou |
IIUC, the error has nothing to do with the |
It seems there is the same problem on another PR: https://github.com/googleapis/storage-testbench/actions/runs/6390316476, so perhaps some upstream dependency changed slightly and broke things? |
I agree, but I
That seems the most likely explanation. Though this code only depends on core Python library modules ( |
Ok, here is a successful build: I've tried to find the package differences between them:
(I would suggest adding a call to Given how the error looks like, I would suggest looking at the Werkzeug update for a potential culprit, and perhaps urllib3. |
@pitrou wow! thanks for the detailed analysis, I am sorry you had to do this. I ran the test with the "success" versions and this may be "a clue":
I am going to send separate PRs to fix the problem, and to pin these indirect dependencies. The latter should help us detect breakages when they are updated. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 50 50
Lines 8007 8007
=======================================
Hits 7903 7903
Misses 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@jorisvandenbossche @raulcd This should make it easier to dissociate the Python version under test from the one used to run the GCS testbench. |
FWIW, I just created a "release" (just a tag really). That may make it easier to use these changes in your CI system. |
Fixes #544