Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send correct content-range header if requested byte range was truncated #622

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Mar 23, 2024

Previously, if the requested byte range was truncated, an invalid content-range header was sent.

…uncated

Previously, if the requested byte range was truncated, an invalid
content-range header was sent.
@jbms jbms requested review from coryan and a team as code owners March 23, 2024 16:27
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (2689610) to head (d8115b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #622   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          50       50           
  Lines        8491     8492    +1     
=======================================
+ Hits         8380     8381    +1     
  Misses        111      111           
Flag Coverage Δ
unittests 98.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@coryan coryan merged commit 281b0e2 into googleapis:main Mar 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants