Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: provide codecov with its token #635

Merged
merged 1 commit into from
Apr 17, 2024
Merged

ci: provide codecov with its token #635

merged 1 commit into from
Apr 17, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Apr 17, 2024

It seems that codecov.io now requires tokens for all uploads:

https://github.com/codecov/codecov-action?tab=readme-ov-file#v4-release

Breaking Changes Tokenless uploading is unsupported

@coryan coryan requested a review from a team as a code owner April 17, 2024 13:25
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (61bce3c) to head (9e9a0c5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #635   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          50       50           
  Lines        8492     8503   +11     
=======================================
+ Hits         8381     8392   +11     
  Misses        111      111           
Flag Coverage Δ
unittests 98.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Carlos!! Could you point me to where to retrieve the codecov token?

@coryan
Copy link
Contributor Author

coryan commented Apr 17, 2024

Awesome, thanks Carlos!! Could you point me to where to retrieve the codecov token?

https://app.codecov.io/gh/googleapis/storage-testbench/settings

@coryan coryan merged commit 56881e4 into googleapis:main Apr 17, 2024
13 checks passed
@coryan coryan deleted the ci-provide-codecov-token branch April 17, 2024 17:46
@cojenco cojenco mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants