Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support retriable stall with controllable delay #666

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

raj-prince
Copy link
Contributor

@raj-prince raj-prince commented Aug 16, 2024

Fixes #667

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

testbench/common.py Outdated Show resolved Hide resolved
testbench/common.py Outdated Show resolved Hide resolved
testbench/common.py Outdated Show resolved Hide resolved
testbench/common.py Outdated Show resolved Hide resolved
@raj-prince raj-prince marked this pull request as ready for review August 20, 2024 14:27
@raj-prince raj-prince requested a review from a team as a code owner August 20, 2024 14:27
@raj-prince raj-prince changed the title [poc] Quick and dirty changes to support fixed number of stall at beginning feat: support retriable stall injection Aug 20, 2024
@raj-prince raj-prince requested a review from frankyn August 20, 2024 14:29
@raj-prince raj-prince changed the title feat: support retriable stall injection feat: support retriable stall with controllable delay Aug 20, 2024
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/test_testbench_retry.py Outdated Show resolved Hide resolved
testbench/common.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (61bce3c) to head (e53b8f4).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   98.69%   98.70%   +0.01%     
==========================================
  Files          50       50              
  Lines        8492     8527      +35     
==========================================
+ Hits         8381     8417      +36     
+ Misses        111      110       -1     
Flag Coverage Δ
unittests 98.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tritone tritone merged commit c4a53b4 into googleapis:main Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for retriable stall
3 participants