Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add write stall support #684

Merged
merged 45 commits into from
Oct 24, 2024
Merged

feat: add write stall support #684

merged 45 commits into from
Oct 24, 2024

Conversation

Tulsishah
Copy link
Contributor

@Tulsishah Tulsishah commented Oct 10, 2024

Fixes #686

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

testbench/common.py Outdated Show resolved Hide resolved
tests/test_testbench_retry.py Show resolved Hide resolved
tests/test_testbench_retry.py Show resolved Hide resolved
testbench/rest_server.py Show resolved Hide resolved
testbench/common.py Show resolved Hide resolved
tests/test_testbench_retry.py Show resolved Hide resolved
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions, generally looking good!

testbench/common.py Show resolved Hide resolved
testbench/rest_server.py Outdated Show resolved Hide resolved
testbench/rest_server.py Show resolved Hide resolved
tests/test_testbench_retry.py Show resolved Hide resolved
@Tulsishah Tulsishah changed the title Write stall support feat: add write stall support Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (61bce3c) to head (7b7a2fe).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   98.69%   98.75%   +0.06%     
==========================================
  Files          50       50              
  Lines        8492     8869     +377     
==========================================
+ Hits         8381     8759     +378     
+ Misses        111      110       -1     
Flag Coverage Δ
unittests 98.75% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review October 18, 2024 04:39
@Tulsishah Tulsishah requested a review from a team as a code owner October 18, 2024 04:39
@Tulsishah
Copy link
Contributor Author

Few suggestions, generally looking good!

Done. PTAL

@Tulsishah Tulsishah requested a review from tritone October 21, 2024 05:23
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

testbench/rest_server.py Show resolved Hide resolved
tests/test_testbench_retry.py Outdated Show resolved Hide resolved
@tritone tritone merged commit dc200a3 into googleapis:main Oct 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stalls for resumable write
3 participants