Skip to content

Commit

Permalink
chore(python): update unittest workflow template (#2008)
Browse files Browse the repository at this point in the history 
* fix: update unittest workflow template

* undo if-no-files-found
  • Loading branch information
@chelsea-lin
chelsea-lin authored Sep 4, 2024
1 parent adf1b0d commit e6f91eb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions synthtool/gcp/templates/python_library/.github/workflows/unittest.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
with:
name: coverage-artifact-${{ '{{' }} matrix.python {{ '}}' }}
path: .coverage-${{ '{{' }} matrix.python {{ '}}' }}
include-hidden-files: true

cover:
runs-on: ubuntu-latest
Expand Down

2 comments on commit e6f91eb

@mukund-ananthu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chelsea-lin The unit test coverage tool started failing in my repository even on PRs for which it was passing earlier. Wanted to check if it is related to this change. Could you please take a look; googleapis/python-pubsub#1227

@chelsea-lin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukund-ananthu The fix in this PR should resolve the problem you're seeing in your repository. It appears the issue was caused by recent automatic updates to the "upload-artifact" tool. The gcf-owl-bot has pulled the latest version of synthtool to your repository: googleapis/python-pubsub#1242, which should be able to address the problem.

Please sign in to comment.