Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make ci testing conditional on engines field in package.json, move configs to Node 12 #1418

Merged
merged 10 commits into from
Apr 14, 2022
Merged

build: make ci testing conditional on engines field in package.json, move configs to Node 12 #1418

merged 10 commits into from
Apr 14, 2022

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Apr 13, 2022 •
edited
Loading

Deleting Node 10 configs here, but we will also have to delete them in each repo.

cc @bcoe

@sofisl sofisl requested a review from a team April 13, 2022 01:26
@sofisl sofisl changed the title build: make ci testing conditional on engines field in package.json build: make ci testing conditional on engines field in package.json, move configs to Node 12 Apr 13, 2022
bcoe
bcoe suggested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking slick to me, left a recommendation for a test and a tiny refactor.

synthtool/languages/node.py Outdated
@@ -48,6 +48,7 @@ def read_metadata():
data["repository"] = f'{repo["owner"]}/{repo["name"]}'
data["repository_name"] = repo["name"]
data["lib_install_cmd"] = f'npm install {data["name"]}'
data["engine"] = data["engines"]["node"].replace(">=", "").replace(".0", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like some of our repos might be >=10.0.0, what you might do is a regex that looks for the first instance of a digit followed by a . and captures it.

I think it would be worth adding a test for this helper, since it's a little finicky.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, PTAL!

bcoe
bcoe reviewed Apr 14, 2022
View reviewed changes
tests/test_node.py Outdated Show resolved Hide resolved
@sofisl sofisl merged commit 2800f5a into master Apr 14, 2022
@sofisl sofisl deleted the moveToNode12 branch April 14, 2022 17:35
loferris pushed a commit that referenced this pull request Apr 19, 2022
@sofisl @bcoe
build: make ci testing conditional on engines field in package.json, …
434798f 
…move configs to Node 12 (#1418)

* build: make ci testing conditional on engines field in package.json, move configs to Node 12

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
parthea added a commit that referenced this pull request Apr 20, 2022
@loferris @parthea
@losalex @tswast @renovate-bot @dandhlee @dependabot @bshaffer @anukaal @tseaver @Neenu1995 @nicain @SurferJeffAtGoogle @busunkim96 @summer-ji-eng @bcoe @sofisl
chore: add function to copy notebook templates (#1420)
b1777ce 
* adding notebook template function

* changing template path

* changing template path

* chore: add googleapis/yoshi-python to CODEOWNERS (#1380)

* chore(python): add E231 to .flake8 ignore list (#1379)

* chore: Enable Size-Label bot in all googleapis Python notebook testing (#1384)

* chore: Enable Size-Label bot in all googleapis Python notebook testing repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Python notebook testing repositories

* Remove product 

Remove product since it is by default true

* chore(python): Enable size-label bot (#1383)

* chore: Enable Size-Label bot in all googleapis Python repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Python repositories

* Remove product 

Remove product since it is by default true

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(python): update .pre-commit-config.yaml to use black==22.3.0 (#1378)

Co-authored-by: Tim Swast <swast@google.com>

* chore(python): Enable size-label bot (#1385)

* chore: remove dependency on google-api-core (#1372)

* chore(deps): update dependency google-api-core to v2.7.1

* chore: remove dependency on google-api-core

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency numpy to v1.22.3 (#1387)

* chore(deps): disable dependency dashboard (#1223)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency pandas to v1.4.1 (#1258)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* build(deps): bump ipython (#1336)

Bumps [ipython](https://github.com/ipython/ipython) from 7.0 to 7.16.3.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@7.0.0...7.16.3)

---
updated-dependencies:
- dependency-name: ipython
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: remove use of googleapis-discovery (#1280)

* chore: remove use of googleapis-discovery

* remove constant and method for googleapis-discovery

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: add classifiers for python 3.7, 3.8 and 3.9 (#1247)

added Support for python 3.7, 3.8, 3.9

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(python): refactor unit / system test dependency install (#1294)

* chore(python): refactor unit / system test dependency install

Closes #1185.

* chore: use editable installs for local deps

* chore: don't install deps using '-e'

* chore: deprecate 'unit_test_external_dependencies'

* fix: install standard + main unit test deps together

FBO pip resolver.

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(python_notebooks): update dependency black to v22 (#1396)

* chore(deps): update dependency ipython to v8 (#1397)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: Enable Size-Label bot in all googleapis NodeJs repositories (#1382)

* chore: Enable Size-Label bot in all googleapis NodeJs repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis NodeJs repositories

* Remove product

Remove product since it is by default true

* chore(deps): update dependency setuptools to v61 (#1398)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency org.sonatype.plugins:nexus-staging-maven-plugin to v1.6.12 (#1388)

Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>

* ci: update testing pipeline for notebooks (#1345)

* update testing pipeline

* kokoro fix

* fixing linting errors

* Update synthtool/gcp/templates/python_notebooks_testing_pipeline/.cloud-build/execute_changed_notebooks_cli.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* Update synthtool/gcp/templates/python_notebooks_testing_pipeline/.cloud-build/execute_changed_notebooks_cli.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* resolving license year

* removing redundant print statements

* adding developer todos

* reverting protos

* resetting protos to main

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update actions/setup-python action to v3 (#1395)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: upgrade black in noxfile.py to 22.3.0 (#1377)

* chore: upgrade black to 22.3.0

* update lint also

* run blacken session

* ci: use click>8.0 for blacken/lint sessions

* chore: fix typo

Co-authored-by: nicain <nicholascain@google.com>

* rebase error

Co-authored-by: nicain <nicholascain@google.com>

* chore(deps): update dependency pandas to v1.4.2 (#1400)

* chore(deps): update dependency setuptools to v61.3.1 (#1399)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency nbqa to v1.3.1 (#1391)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency protobuf to v3.19.4 (#1389)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency protobuf to v3.20.0 (#1403)

* chore(deps): update dependency setuptools to v62 (#1406)

* chore(python): Use python 3.10.4 base image for post processor (#1405)

* chore(deps): update actions/setup-node action to v3 (#1393)

Co-authored-by: Jeffrey Rennie <rennie@google.com>

* chore(python): add license header to auto-label.yaml (#1404)

* chore: improve logic to configure release-please for previous major versions (#1408)

* fix: allow version.py files without the library version

* chore: remove obsolete file

* chore: run black

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore: Enable Size-Label bot in all googleapis Java repositories (#1381)

* chore: Enable Size-Label bot in all googleapis Java repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories

* Remove product 

Remove product since it is by default true

* add license header

Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>

* chore(deps): update actions/checkout action to v3 (#1392)

Co-authored-by: Jeffrey Rennie <rennie@google.com>

* chore: run tests with Python 3.10 (#1407)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency python to v3.10.4 (#1386)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Jeffrey Rennie <rennie@google.com>

* fix: clarify the gax-nodejs usage in README (#1352)

Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: Jeffrey Rennie <rennie@google.com>

* Revert "fix: clarify the gax-nodejs usage in README (#1352)" (#1409)

This reverts commit e1557e4.

* chore(deps): update dependency pyupgrade to v2.32.0 (#1412)

* chore(deps): update dependency nbconvert to v6.5.0 (#1414)

* build: make ci testing conditional on engines field in package.json, move configs to Node 12 (#1418)

* build: make ci testing conditional on engines field in package.json, move configs to Node 12

Co-authored-by: Benjamin E. Coe <bencoe@google.com>

* build: sdd srs yaml file (#1419)

* build: add sync-repo-settings and change branch protection

* update names for template

* adding type annotation

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: losalex <90795544+losalex@users.noreply.github.com>
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Brent Shaffer <betterbrent@google.com>
Co-authored-by: Anurag Kumar <mailanu98@gmail.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com>
Co-authored-by: nicain <nicholascain@google.com>
Co-authored-by: Jeffrey Rennie <rennie@google.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Summer Ji <summerji@google.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

@chingor13 chingor13 Awaiting requested review from chingor13 chingor13 is a code owner

@ddelgrosso1 ddelgrosso1 Awaiting requested review from ddelgrosso1

@danielbankhead danielbankhead Awaiting requested review from danielbankhead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofisl @bcoe