Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin flake8 to v < 6.0.0 #1716

Closed
wants to merge 2 commits into from
Closed

fix: Pin flake8 to v < 6.0.0 #1716

wants to merge 2 commits into from

Conversation

Mariatta
Copy link
Contributor

flake8 v 6.0.0 introduces backward incompatible change. flake8-import-order is broken because of it.
Until there is an updated version of flake8-import-order, we will need to pin flake8 to v<6.0.0

@Mariatta Mariatta requested a review from a team as a code owner November 24, 2022 17:46
@Mariatta Mariatta changed the title Pin flake8 to v < 6.0.0 fix: Pin flake8 to v < 6.0.0 Nov 24, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

flake8 v 6.0.0 introduces backward incompatible change.
flake8-import-order is broken because of it.
Until there is an updated version of flake8-import-order, we will need to pin flake8 to v<6.0.0
@Mariatta
Copy link
Contributor Author

A fix was made in flake8-import-order but they have not cut a release yet.
PyCQA/flake8-import-order#190

@Mariatta
Copy link
Contributor Author

Closing in favor of #1717

@Mariatta Mariatta closed this Nov 24, 2022
@Mariatta Mariatta deleted the Mariatta-patch-1 branch November 24, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants