Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add links to the CHANGELOG from the README.md for Java and Node #701

Merged
merged 7 commits into from
Jul 30, 2020

Conversation

feywind
Copy link
Contributor

@feywind feywind commented Jul 29, 2020

This is for making this user-requested change global across repos that have a README.

googleapis/nodejs-pubsub#1067

I didn't see equivalents for the other languages... is that something we want to figure out? Or just go with these two for now?

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2020
@feywind feywind force-pushed the add-readme-changelog branch from f9a9081 to faf025f Compare July 29, 2020 19:59
@feywind
Copy link
Contributor Author

feywind commented Jul 29, 2020

Ahh the joys of learning a new keyboard :D

@feywind
Copy link
Contributor Author

feywind commented Jul 29, 2020

I'm moving this back to just Node, because that's the immediate need, and most of the Java repos don't seem to use the generated README anyway.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with a nit that's personal opinion.

synthtool/gcp/templates/node_library/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants