-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add links to the CHANGELOG from the README.md for Java and Node #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 29, 2020
feywind
force-pushed
the
add-readme-changelog
branch
from
July 29, 2020 19:59
f9a9081
to
faf025f
Compare
Ahh the joys of learning a new keyboard :D |
I'm moving this back to just Node, because that's the immediate need, and most of the Java repos don't seem to use the generated README anyway. |
JustinBeckwith
approved these changes
Jul 30, 2020
bcoe
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with a nit that's personal opinion.
SurferJeffAtGoogle
approved these changes
Jul 30, 2020
bcoe
approved these changes
Jul 30, 2020
This was referenced Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for making this user-requested change global across repos that have a README.
googleapis/nodejs-pubsub#1067
I didn't see equivalents for the other languages... is that something we want to figure out? Or just go with these two for now?