Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: only check --engine-strict for production deps #810

Merged
merged 3 commits into from
Oct 16, 2020
Merged

build: only check --engine-strict for production deps #810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb615cb
build: only check --engine-strict for production deps
bcoe Oct 15, 2020
d2346eb
Merge branch 'master' into fix-engines-check
bcoe Oct 15, 2020
a1cbffe
Merge branch 'master' into fix-engines-check
JustinBeckwith Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion synthtool/gcp/templates/node_library/.github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ jobs:
with:
node-version: ${{ '{{' }} matrix.node {{ '}}' }}
- run: node --version
- run: npm install --engine-strict
# The first installation step ensures that all of our production
# dependencies work on the given Node.js version, this helps us find
# dependencies that don't match our engines field:
- run: npm install --production --engine-strict
- run: npm install
- run: npm test
- name: coverage
uses: codecov/codecov-action@v1
Expand Down