Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update badge link in README #173

Merged
merged 1 commit into from
Jun 1, 2020
Merged

chore(docs): update badge link in README #173

merged 1 commit into from
Jun 1, 2020

Conversation

davidkhala
Copy link
Contributor

@davidkhala davidkhala commented May 29, 2020

Fix broken badge link and svg

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #174 🦕

Fix broken badge link and svg
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files           3        3           
  Lines         630      630           
  Branches       52       52           
=======================================
  Hits          528      528           
  Misses        102      102           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7727ba2...c4df7ff. Read the comment docs.

@davidkhala
Copy link
Contributor Author

OOP, it seems I have to follow all the steps even for a simple doc change.

@davidkhala
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 29, 2020
@stephenplusplus
Copy link
Contributor

Thanks for going through all of that for such a simple change! After CI gives us the all-green, we can merge this in. Thanks again for catching that and sending the fix.

@stephenplusplus stephenplusplus changed the title Update README.md chores(docs): update badge link in README May 29, 2020
@stephenplusplus stephenplusplus changed the title chores(docs): update badge link in README chore(docs): update badge link in README May 29, 2020
@davidkhala
Copy link
Contributor Author

Personal curiosity, why the automated build will last for several days? Does it mean this is still waiting in a long build queue?

@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2020
@stephenplusplus
Copy link
Contributor

Personal curiosity, why the automated build will last for several days? Does it mean this is still waiting in a long build queue?

Sometimes, we are in a big queue, but in this case, it could be that our internal test runner (Kokoro) fell asleep and needs a quick kick. I'm afraid I can't be more specific-- I really don't know why it flops on us sometime :( Kicking complete, though, so let's see if that helps!

@stephenplusplus stephenplusplus merged commit 58b5a63 into googleapis:master Jun 1, 2020
@davidkhala davidkhala deleted the patch-1 branch June 2, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken badge link and svg
4 participants