-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update badge link in README #173
Conversation
Fix broken badge link and svg
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 3 3
Lines 630 630
Branches 52 52
=======================================
Hits 528 528
Misses 102 102 Continue to review full report at Codecov.
|
OOP, it seems I have to follow all the steps even for a simple doc change. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for going through all of that for such a simple change! After CI gives us the all-green, we can merge this in. Thanks again for catching that and sending the fix. |
Personal curiosity, why the automated build will last for several days? Does it mean this is still waiting in a long build queue? |
Sometimes, we are in a big queue, but in this case, it could be that our internal test runner (Kokoro) fell asleep and needs a quick kick. I'm afraid I can't be more specific-- I really don't know why it flops on us sometime :( Kicking complete, though, so let's see if that helps! |
Fix broken badge link and svg
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #174 🦕