This repository has been archived by the owner on May 15, 2019. It is now read-only.
Fix/207 linux hot reloading #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdobry
reviewed
Jul 20, 2018
src/supervisor/worker.js
Outdated
| } | ||
| } | ||
| } | ||
| if (localdir && message.watch) { |
There was a problem hiding this comment.
Why change this conditional? Reloading the function while in debug mode will break whatever debugging the user is doing if a file changes while they're debugging.
There was a problem hiding this comment.
Thanks for reviewing! I think I wanted to test/debug the block of code, removed the conditional and then forgot to add it back (as you do 😆) - good catch.
jmdobry
approved these changes
Jul 25, 2018
|
Umm... does it normally take more than a month for CircleCI checks to complete? 😅 |
|
Any update here? |
jmdobry
approved these changes
Nov 16, 2018
|
any idea when this fix is coming to the latest npm packge ?? |
|
Still a couple failing tests after the dependency upgrades, stay tuned... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207 (hopefully)
Using
chokidarfor file watching in the worker which fixes hot reloading on Linux.