-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(predictive-perf): predict FCP #3730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm interested in keeping the FMP prediction, for now.
Until we have an actual midpoint metric replacement I don't think we can remove FMP entirely. (see also #3672)
I'm inclined to reduce churn in exposing until we have a concrete plan for what we expose ala #3761, but I agree so I changed to just add FCP and not touch FMP |
78875e9
to
8b0f2b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me.
As we were talking about, maybe add extendedInfo
entries for first approximations at estimates, even if they're only in the ballpark of where we're going with this? Happy to go with awkward names that discourage treating them as more than placeholders :)
* core(predictive-perf): predict FCP instead of FMP * add back FMP * add rough estimates
closes #3671
closes #3593
Adds prediction of FCP, similar to FMP but move the time boundary to observed FCP, remove the CPU layout tasks, and add in the EvaluateScript tasks of blocking scripts (which really could have been part of FMP prediction too).
I also added redirects support since FCP was more radically impacted by missing redirect support than FMP was. I dug into a lot of the larger error cases (where error was >1s) and at this point small differences should not be used for decision making.
Some notable examples:
Overall, we're about as accurate as we were with FMP, higher error at the tail but lower error for most sites. Further progress on accuracy will need higher fidelity throttling like WPT.
Accuracy comparison