core(metrics): add FCP metric #4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
approved these changes
Apr 10, 2018
| const Util = require('../report/v2/renderer/util.js'); | ||
|
|
||
| // eslint-disable-next-line max-len | ||
| const LEARN_MORE_LINK = 'https://developers.google.com/web/fundamentals/performance/user-centric-performance-metrics#first_paint_and_first_contentful_paint'; |
There was a problem hiding this comment.
I believe you can just inline this and max-len will accept it since it has a url in it
|
|
||
| class FirstContentfulPaint extends Audit { | ||
| /** | ||
| * @return {!AuditMeta} |
| /** | ||
| * @param {!Artifacts} artifacts | ||
| * @param {LH.Audit.Context} context | ||
| * @return {!Promise<!AuditResult>} |
There was a problem hiding this comment.
LH.Artifacts and Promise<LH.Audit.Product> for future us :)
| */ | ||
| computeObservedMetric(data) { | ||
| const {traceOfTab} = data; | ||
| if (!traceOfTab) { |
There was a problem hiding this comment.
hmm, this is kind of unfortunate to check here, but it looks like at least tsc alerts you based on MetricComputationData? Should we always require a trace for ComputedMetric? I assume you made traceOfTab optional for a reason, though
There was a problem hiding this comment.
yeah I just split MetricComputationData into two so we don't have to do this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress on #4872