New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix defaultConfig UIStrings and exit code for test #5884

Merged

paulirish merged 1 commit into master from fixdefault

Aug 21, 2018

Member

brendankenny commented Aug 21, 2018

fix module.exports ordering issue introduced by #5858

Also makes the i18n:checks test fail if collect-strings.js throws an error


          core: fix defaultConfig UIStrings and exit code for test

brendankenny requested a review from patrickhulce as a code owner

August 21, 2018 01:26

paulirish approved these changes

View reviewed changes

paulirish merged commit 79a9a5f into master

paulirish deleted the fixdefault branch

August 21, 2018 23:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet