clients(devtools): unset overflow in print #9274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested changes
Jun 25, 2019
| @@ -263,6 +263,11 @@ | |||
| overflow-y: scroll; | |||
| height: calc(100% - var(--topbar-height)); | |||
| } | |||
| @media print { | |||
| .lh-devtools .lh-container { | |||
| height: inherit; | |||
There was a problem hiding this comment.
i tried this out and i'm not sure it fixes the issue.
rather than height, i'm pretty sure we need to unset the overflow property back to 'visible' instead.
@media print {
.lh-devtools .lh-container {
overflow-y: unset;
}
}There was a problem hiding this comment.
worked for me
Try it out in this manner:
comment out the "printWindow.close()" fn, cancel the print prompt when it appears, and inspect the print window / apply these styles
There was a problem hiding this comment.
it was only barely working :)
fixed
paulirish
approved these changes
Jun 25, 2019
connorjclark
changed the title
connorjclark
added a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://chromium-review.googlesource.com/c/chromium/src/+/1651062/14/third_party/blink/renderer/devtools/front_end/audits/AuditsReportRenderer.js#b34