Skip to content
This repository has been archived by the owner on Sep 3, 2022. It is now read-only.

Modify async to async_ to avoid reserved keyword clash. #728

Merged
merged 5 commits into from
Mar 24, 2020

Conversation

crwilcox
Copy link
Contributor

Fixes #711 by refactoring use of a reserved keyword.
Add test pass for Python 3.7

@crwilcox crwilcox changed the title Modify async to _async to avoid reserved keyword clash. Modify async to async_ to avoid reserved keyword clash. Mar 10, 2020
@crwilcox crwilcox force-pushed the 3-7-compatibility branch from 6d197d7 to b2675d6 Compare March 10, 2020 19:13
@coveralls
Copy link

coveralls commented Mar 10, 2020

Coverage Status

Coverage remained the same at 77.873% when pulling 1922b5f on crwilcox:3-7-compatibility into 8c2df84 on googledatalab:master.

seii-saintway
seii-saintway previously approved these changes Mar 11, 2020
Copy link

@francois-baptiste francois-baptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work like a charm, thanks!
(pip install git+https://github.com/crwilcox/pydatalab.git@3-7-compatibility)

Copy link

@paveldournov paveldournov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crwilcox crwilcox merged commit 8573ff3 into googledatalab:master Mar 24, 2020
@crwilcox crwilcox mentioned this pull request Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Python 3.7
6 participants