maximum_color_test: reproduce #435 input file contains spaces

googlefonts · Nov 18, 2022 · b77f5ed · b77f5ed
1 parent cefcacd
commit b77f5ed
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/tests/maximum_color_test.py b/tests/maximum_color_test.py
@@ -63,6 +63,14 @@ def _maximize_color(initial_font_file: Path, additional_flags: Tuple[str, ...])
     return maxmium_font_file
 
 
+@pytest.mark.parametrize(
+    "input_file",
+    [
+        "Font.ttf",
+        # test that we don't crash when filename contains spaces
+        "Color Font.ttf",
+    ],
+)
 @pytest.mark.parametrize(
     "color_format, expected_new_tables",
     [
@@ -71,18 +79,21 @@ def _maximize_color(initial_font_file: Path, additional_flags: Tuple[str, ...])
     ],
 )
 @pytest.mark.parametrize("bitmaps", [True, False])
-def test_build_maximum_font(color_format, expected_new_tables, bitmaps):
+def test_build_maximum_font(color_format, expected_new_tables, bitmaps, input_file):
     initial_font_file = _build_initial_font(color_format)
 
+    input_file = initial_font_file.parent / input_file
+    initial_font_file.rename(input_file)
+
     bitmap_flag = "--nobitmaps"
     if bitmaps:
         bitmap_flag = "--bitmaps"
         expected_new_tables = copy.copy(expected_new_tables)
         expected_new_tables.update({"CBDT", "CBLC"})
 
-    maxmium_font_file = _maximize_color(initial_font_file, (bitmap_flag,))
+    maxmium_font_file = _maximize_color(input_file, (bitmap_flag,))
 
-    initial_font = ttLib.TTFont(initial_font_file)
+    initial_font = ttLib.TTFont(input_file)
     maximum_font = ttLib.TTFont(maxmium_font_file)
     assert set(maximum_font.keys()) - set(initial_font.keys()) == expected_new_tables