-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from deprecated toml
library
#451
Comments
thanks for the reminder. yes we should switch at some point. Are the APIs similar enough that one can use these as drop-in replacements? |
I'm afraid but I have encountered a major issue with tomlkit python-poetry/tomlkit#309, thus I will have to revert the #452 PR for now. |
@CyberTailor In this issue you mentioned tomli but in the PR #452 you ended up using tomlkit. May I ask why? |
for reference, these are the CI build failures that I was seeing, which led me to file the above mentioned issue python-poetry/tomlkit#309: https://github.com/googlefonts/nanoemoji/actions/runs/5762993401/job/15623882139 I pushed the revert commit to this PR #462 |
The replacement is Python's 3.11
tomllib
module andtomli
package for older versions.The text was updated successfully, but these errors were encountered: