Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated toml library #451

Open
CyberTailor opened this issue May 18, 2023 · 6 comments · Fixed by #452
Open

Switch from deprecated toml library #451

CyberTailor opened this issue May 18, 2023 · 6 comments · Fixed by #452

Comments

@CyberTailor
Copy link
Contributor

The replacement is Python's 3.11 tomllib module and tomli package for older versions.

@anthrotype
Copy link
Member

thanks for the reminder. yes we should switch at some point. Are the APIs similar enough that one can use these as drop-in replacements?
Are you volunteering to send on a PR? :)

CyberTailor added a commit to CyberTailor/nanoemoji that referenced this issue May 21, 2023
CyberTailor added a commit to CyberTailor/nanoemoji that referenced this issue May 22, 2023
CyberTailor added a commit to CyberTailor/nanoemoji that referenced this issue May 22, 2023
CyberTailor added a commit to CyberTailor/nanoemoji that referenced this issue May 22, 2023
@anthrotype anthrotype reopened this Aug 4, 2023
@anthrotype
Copy link
Member

I'm afraid but I have encountered a major issue with tomlkit python-poetry/tomlkit#309, thus I will have to revert the #452 PR for now.

@anthrotype
Copy link
Member

anthrotype commented Aug 4, 2023

@CyberTailor In this issue you mentioned tomli but in the PR #452 you ended up using tomlkit. May I ask why?

@anthrotype
Copy link
Member

anthrotype commented Aug 4, 2023

for reference, these are the CI build failures that I was seeing, which led me to file the above mentioned issue python-poetry/tomlkit#309:

https://github.com/googlefonts/nanoemoji/actions/runs/5762993401/job/15623882139

I pushed the revert commit to this PR #462

@CyberTailor
Copy link
Contributor Author

In this issue you mentioned tomli but in the PR #452 you ended up using tomlkit. May I ask why?

tomli has no write support

@anthrotype
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants