Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[colr_to_svg] drop unsupported PaintComposites with a warning #411

Merged
merged 1 commit into from
Apr 27, 2022
Merged

[colr_to_svg] drop unsupported PaintComposites with a warning #411

merged 1 commit into from
Apr 27, 2022

Conversation

anthrotype
Copy link
Member

Fixes #409 for now

@anthrotype
Copy link
Member Author

original COLRv1 flag (with soft-light effect via PaintComposite) in Chrome

Screen Shot 2022-04-26 at 11 43 12

converted SVG flag (without soft-light effect) in Safari

Screen Shot 2022-04-26 at 11 43 18

rsheeter
rsheeter approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@rsheeter rsheeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty. QQ, do you know what the ticket(s) are for browser support for filters in ot-svg?

@anthrotype
Copy link
Member Author

anthrotype commented Apr 27, 2022 •
edited
Loading

this is the one with FireFox <feImage xlink:href="..."/> not working with fragments within the same doc: https://bugzilla.mozilla.org/show_bug.cgi?id=455986

@anthrotype anthrotype merged commit f5778ec into main Apr 27, 2022
@anthrotype anthrotype deleted the drop-unsupported-composite branch April 27, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsheeter rsheeter rsheeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noto Emoji flags fail maximum_color due to soft light
2 participants
@anthrotype @rsheeter