Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take first in multi-palette CPAL; convert 0xFFFF palette index to SVG fill="currentColor" #423

Merged
merged 3 commits into from
Aug 18, 2022
Merged

take first in multi-palette CPAL; convert 0xFFFF palette index to SVG fill="currentColor" #423

merged 3 commits into from
Aug 18, 2022

Conversation

anthrotype
Copy link
Member

in an attempt to fix #421 and allow ReekKufiInk be converted from COLRv1 to OT-SVG...

@anthrotype anthrotype marked this pull request as draft July 29, 2022 15:23
@anthrotype anthrotype mentioned this pull request Jul 29, 2022
Closed
@rsheeter
Copy link
Collaborator

I do wonder if the 0 width check shouldn't still exist somewhere for bitmaps only. Still seems like a good change. Can we add something like a very narrow subset of the arabic mark example to expose these issues in a test?

@anthrotype
Copy link
Member Author

i'll disentangle the issue about multiple CPAL palettes (this PR) from the one about zero-width glyphs, for which I am filing a separate PR #424

@anthrotype anthrotype changed the title take first in multi-palette CPAL; allow 0-width glyphs take first in multi-palette CPAL Aug 18, 2022
@anthrotype anthrotype marked this pull request as ready for review August 18, 2022 15:19
@anthrotype
Copy link
Member Author

I rebased this on top of #424, so the latter should be merged first. This PR basically adds the last commit 6e8e43c

@anthrotype anthrotype changed the title take first in multi-palette CPAL take first in multi-palette CPAL; convert 0xFFFF palette index to SVG fill="currentColor" Aug 18, 2022
@anthrotype
Copy link
Member Author

anthrotype commented Aug 18, 2022 •
edited
Loading

@rsheeter I also took the liberty to fix #405 with 3807fc3 since I was touching those lines anyway and was a small fix

@rsheeter
Copy link
Collaborator

Nice. Once this is merged/released you should maximum_color reem kufi ink on google/fonts :)

@anthrotype anthrotype merged commit 0811a64 into main Aug 18, 2022
@anthrotype anthrotype deleted the fix-421 branch August 18, 2022 17:07
@anthrotype
Copy link
Member Author

Once this is merged/released...

https://github.com/googlefonts/nanoemoji/releases/tag/v0.14.0

@anthrotype
Copy link
Member Author

...you should maximum_color reem kufi ink on google/fonts :)

FYI I'm travelling tomorrow so I won't be able to do that until next week (in cause you want to give that a try)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsheeter rsheeter rsheeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maximum_color is unhappy with > 1 palette
2 participants
@anthrotype @rsheeter