Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colored .notdef moving position when its shapes get reused #430

Merged
merged 4 commits into from
Sep 1, 2022

Conversation

anthrotype
Copy link
Member

Fixes #429

@anthrotype
Copy link
Member Author

https://github.com/googlefonts/nanoemoji/runs/8135728983?check_suite_focus=true#step:5:69 shows how a colored .notdef is no longer in the first position if its shapes get reused by a following color glyph (in the test I made the glyph "C" identical to the .notdef to force it being reused).

@anthrotype anthrotype merged commit 29ba5bd into main Sep 1, 2022
@anthrotype anthrotype deleted the fix-double-notdef branch September 1, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maximum_color v0.14.2 still fails with some fonts with colored .notdef glyph
1 participant