Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse of arcs is poor #271

Open
rsheeter opened this issue May 15, 2022 · 3 comments
Open

Reuse of arcs is poor #271

rsheeter opened this issue May 15, 2022 · 3 comments
Assignees
@rsheeter

Comments

@rsheeter
Copy link
Collaborator

rsheeter commented May 15, 2022 •
edited
Loading

Shapes like this fail to find reuse:

0

Appears to relate to arcs, specifically arcs whose start/end is almost the same for at least one dimension. For example,

M104.64,10.08   A40.64 6.08 0 1 1 23.36,10.08   A40.64 6.08 0 1 1 104.64,10.08 Z
M99.63,23.34     A36.19 4.81 0 1 1 27.25,23.34   A36.19 4.81 0 1 1 99.63,23.34 Z

Because the arcs start/end has identical y we fail to compute a y-scale adjustment.

Observed in sanity checking nanoemoji part files for ones that failed (donor is null).
@rsheeter rsheeter self-assigned this May 15, 2022
@rsheeter
Copy link
Collaborator Author

rsheeter commented Jun 1, 2022

I just like this example :)

image

@rsheeter rsheeter mentioned this issue Jun 4, 2022
Merged
@anthrotype
Copy link
Member

what's not fixed with #272?

@rsheeter
Copy link
Collaborator Author

rsheeter commented Jun 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsheeter rsheeter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsheeter @anthrotype