Better shape reuse identification #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Sep 30, 2020
| """Returns equivalent path with only absolute commands.""" | ||
| return self._rewrite_path(_relative_to_absolute, inplace) | ||
|
|
||
| def relative(self, inplace=False) -> "SVGPath": |
There was a problem hiding this comment.
nice, we could use this for #94
anthrotype
reviewed
Oct 28, 2020
rsheeter
changed the title
Upon further investigation some of them are more nefarious than expected: same shape, different drawing commands. I think we'll say Shape Reuse as a project is not done but this PR has moved as far as it intended so I would like to merge. Some examples of shapes that don't reuse are captured in #125. |
rsheeter
force-pushed
the
normalize2
branch
3 times, most recently
from
eaea959
to
5be6921
Compare
anthrotype
reviewed
Nov 6, 2020
anthrotype
reviewed
Nov 6, 2020
rsheeter
force-pushed
the
normalize2
branch
2 times, most recently
from
93fe078
to
819920f
Compare
… etc. Address some review comments.
Co-authored-by: Cosimo Lupo <clupo@google.com>
anthrotype
reviewed
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved implementation of shape reuse detection.
Annoyingly not working well for real sample data from Noto https://rsheeter.github.io/android_fonts/emoji.html?q=u:1f970 just yet; normalized shapes only match to 1 decimal place. Good chance I've done something silly and introduced enormous numeric instability.
EDIT: at least some of the paths are actually different despite the shapes being visually the same post-normalization. I think there may be ways to solve this but they are well beyond the intended scope of this PR.