Skip to content

Commit

Permalink
Meta: Contributor role (#3922)
Browse files Browse the repository at this point in the history
We had a loosely defined contributor role, but this standardises it
across our contributing guides.

Also specifies that a user needs to have at least one PR merged before
becoming a contributor, which was implied but never explicitly stated
(making things hard for would be contributors!).
  • Loading branch information
markmandel authored Jul 25, 2024
1 parent eb08f0b commit eec6f7c
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 4 deletions.
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/become-a-repo-collaborator.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Give us a few days to review and you should receive an invitation to join. Once

### Requirements

- [ ] I have at least one merged Pull Request
- [ ] I have reviewed the [contribution guidelines](https://github.com/googleforgames/agones/blob/main/CONTRIBUTING.md)
- [ ] I have enabled [2FA on my GitHub account](https://github.com/settings/security)
- [ ] I have joined the [Agones Slack workspace](https://join.slack.com/t/agones/shared_invite/zt-2mg1j7ddw-0QYA9IAvFFRKw51ZBK6mkQ)
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,13 @@ You can see them on our calendar
[mailing list or Slack](https://agones.dev/site/community/)
for notifications.

## Becoming a Contributor on Agones

If you have submitted at least one Pull Request and had it merged, you may wish to become an official contributor.
This will give you the ability to have tickets assigned to you (or you can assign tickets to yourself!).

We have a [community membership guide](./docs/governance/community_membership.md), that outlines the process.

## Becoming an Approver on Agones

If you are interested in becoming an Approver on the Agones project and getting commit access to the
Expand Down
26 changes: 22 additions & 4 deletions docs/governance/community_membership.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ This is based on the [Kubernetes Community Membership](https://github.com/kubern

There are currently two roles for this project, but that may grow in the future.

| Role | Responsibilities | Requirements | Defined by |
| -----| ---------------- | ------------ | -------|
| Releaser | Create Agones releases | Sponsored by 2 approvers | Commit access to the Agones repository |
| Approver | Review and approve contributions | Sponsored by 2 approvers and multiple contributions to the project | Commit access to the Agones repository and [OWNERS] file approver entry |
| Role | Responsibilities | Requirements | Defined by |
|-------------|----------------------------------|--------------------------------------------------------------------|-------------------------------------------------------------------------|
| Contributor | Can have tickets assigned | Have one PR merged | Read access to the Agones repository |
| Releaser | Create Agones releases | Sponsored by 2 approvers | Commit access to the Agones repository |
| Approver | Review and approve contributions | Sponsored by 2 approvers and multiple contributions to the project | Commit access to the Agones repository and [OWNERS] file approver entry |


## New contributors
Expand All @@ -26,6 +27,23 @@ policies, procedures, conventions, etc., and technical and/or writing ability.
Role-specific expectations, responsibilities, and requirements are enumerated
below.

## Contributor

For regular contributors that wish to have issues assigned to them, we have the contributor role.

To become a contributor, create an issue using the
[become a repo collaborator issue template](https://github.com/googleforgames/agones/issues/new?assignees=thisisnotapril&labels=area%2Fcommunity&projects=&template=become-a-repo-collaborator.md&title=Collaborator+Request)
and we will review it as a team.

**Defined by:** Read access to the Agones repository.

### Requirements

- Have at least one merged Pull Request.
- Have reviewed the [contribution guidelines](https://github.com/googleforgames/agones/blob/main/CONTRIBUTING.md)
- Have enabled [2FA on my GitHub account](https://github.com/settings/security)
- Have joined the [Agones Slack workspace](https://join.slack.com/t/agones/shared_invite/zt-2mg1j7ddw-0QYA9IAvFFRKw51ZBK6mkQ)

## Releaser

Releasers are engineers that are able to commit to the Agones repository with
Expand Down

0 comments on commit eec6f7c

Please sign in to comment.