Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky: TestSDKServerRemoveListValue #3625

Closed
Kalaiselvi84 opened this issue Jan 31, 2024 · 0 comments · Fixed by #3627
Closed

Flaky: TestSDKServerRemoveListValue #3625

Kalaiselvi84 opened this issue Jan 31, 2024 · 0 comments · Fixed by #3627
Labels
kind/bug These are bugs.

Comments

@Kalaiselvi84
Copy link
Contributor

What happened:

--- FAIL: TestSDKServerRemoveListValue (16.32s)
    --- FAIL: TestSDKServerRemoveListValue/Remove_all_values (1.12s)
        sdkserver_test.go:1626: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1626
            	Error:      	Not equal: 
            	            	expected: v1.ListStatus{Capacity:100, Values:[]string{}}
            	            	actual  : v1.ListStatus{Capacity:100, Values:[]string{"one"}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -2,3 +2,4 @@
            	            	  Capacity: (int64) 100,
            	            	- Values: ([]string) {
            	            	+ Values: ([]string) (len=1) {
            	            	+  (string) (len=3) "one"
            	            	  }
            	Test:       	TestSDKServerRemoveListValue/Remove_all_values
        sdkserver_test.go:1636: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1636
            	Error:      	Not equal: 
            	            	expected: 0
            	            	actual  : 1
            	Test:       	TestSDKServerRemoveListValue/Remove_all_values

What you expected to happen:
Tests to pass

How to reproduce it (as minimally and precisely as possible):
Not entirely sure. Seems to mostly happen in CI, have yet to try and reproduce locally.

Anything else we need to know?:

Environment:

  • Agones version: dev
  • Kubernetes version (use kubectl version): varies
  • Cloud provider or hardware configuration: GKE
  • Install method (yaml/helm): helm
  • Troubleshooting guide log(s): Log included in What happend section
  • Others: N/A
@Kalaiselvi84 Kalaiselvi84 added the kind/bug These are bugs. label Jan 31, 2024
markmandel added a commit to markmandel/agones that referenced this issue Feb 1, 2024
Both unit tests had the same issue - under high load, the workqueue
could process the current data set that was batched for updates,
resulting in non-deterministic test state.

Moving the `sc.Run(...)` operation until only the moment where update
checks are required resolves this issue.

Fixes googleforgames#3625
Fixes googleforgames#3622
roberthbailey pushed a commit that referenced this issue Feb 1, 2024
Both unit tests had the same issue - under high load, the workqueue
could process the current data set that was batched for updates,
resulting in non-deterministic test state.

Moving the `sc.Run(...)` operation until only the moment where update
checks are required resolves this issue.

Fixes #3625
Fixes #3622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant