Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Param Update: Default to agones.controller if agones.extensions is Missing #3772

Closed
Kalaiselvi84 opened this issue Apr 17, 2024 · 2 comments · Fixed by #3773
Closed
Assignees
Labels
kind/bug These are bugs.

Comments

@Kalaiselvi84
Copy link
Contributor

What happened:
The Helm chart uses old parameters under .Values.agones.controller which were supposed to be migrated to .Values.agones.extensions.

What you expected to happen:
Replace with new parameters under .Values.agones.extensions. The Helm chart should allow for backward compatibility by defaulting to old parameters if new ones are not set.

Anything else we need to know?:
This issue requires updating the Helm chart to include fallback mechanisms using default and or empty functions to ensure configurations using old parameters still function correctly.

https://helm.sh/docs/chart_template_guide/function_list/#default
https://helm.sh/docs/chart_template_guide/function_list/#empty

@markmandel
Copy link
Member

Just a note - it's not all the .Values.agones.controller values, it's just the items that were highlighted in:
https://github.com/googleforgames/agones/pull/3735/files

So basically the things that affect the extensions - controller should stay the same.

@Kalaiselvi84 Kalaiselvi84 changed the title Complete Migration of agones.controller Parameters to New agones.extensions Helm Param Update: Default to agones.controller if agones.extensions is Missing Apr 17, 2024
@GOOFY635273529
Copy link

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants