Helm Param Update: Default to agones.controller if agones.extensions is Missing #3773

Kalaiselvi84 · 2024-04-17T15:52:44Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3772

Special notes for your reviewer:

agones-bot · 2024-04-17T16:06:18Z

Build Failed 😱

Build Id: f483c0f2-a4cd-44a1-996f-fd0f13ad2900

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

This reverts commit 33ddbcf.

Kalaiselvi84 · 2024-04-17T17:46:20Z

I have updated the necessary changes in the extensions.yaml and helm.md files. If there's anything that still needs to be addressed, please let me know

agones-bot · 2024-04-17T18:08:27Z

Build Failed 😱

Build Id: e032e08d-7b92-4e31-8609-b8a9e15377dc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-17T19:11:42Z

Build Failed 😱

Build Id: 233b4905-be9f-41d1-8b50-6a793d83d6da

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn · 2024-04-18T23:42:00Z

I'm not sure if it does need to change, but please review https://agones.dev/site/docs/advanced/high-availability-agones/#extension-pod-configrations and see if anything in there needs to be modified.

agones-bot · 2024-04-18T23:43:13Z

Build Succeeded 👏

Build Id: d5155843-3e37-4f2a-8772-203fdc91ac66

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://7d9caf7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3773/head:pr_3773 && git checkout pr_3773
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-7d9caf7-amd64

…pdb.maxUnavailable not set

Kalaiselvi84 · 2024-04-19T00:24:59Z

I'm not sure if it does need to change, but please review https://agones.dev/site/docs/advanced/high-availability-agones/#extension-pod-configrations and see if anything in there needs to be modified.

Thanks for pointing this out. The document states that agones.extensions.pdb.minAvailable is set to 1, so I applied the default function to agones.extensions.pdb.maxUnavailable. Please let me know if I'm missing anything

agones-bot · 2024-04-19T03:30:04Z

Build Failed 😱

Build Id: c3dde5b8-b2e2-4b5e-8738-ea75c39cc7ff

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

site/content/en/docs/Installation/Install Agones/helm.md

…ensions.pdb.maxUnavailable not set" This reverts commit 856975a.

zmerlynn

LGTM cc @markmandel

agones-bot · 2024-04-23T17:38:09Z

Build Succeeded 👏

Build Id: 86e858a2-f9f7-4479-a938-ffd12f24e223

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://d529654-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3773/head:pr_3773 && git checkout pr_3773
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-d529654-amd64

markmandel

Looks pretty good to me.

@zmerlynn did you still want to talk about this PR?

markmandel · 2024-04-24T22:20:04Z

site/content/en/docs/Installation/Install Agones/helm.md

@@ -305,17 +305,17 @@ The following tables lists the configurable parameters of the Agones chart and t
 | `agones.extensions.logLevel`                             | Agones Extensions Log level. Log only entries with that severity and above                                                                                                                                                                                                                                       | `info`                                    |
 | `agones.extensions.persistentLogs`                       | Store Agones extensions logs in a temporary volume attached to a container for debugging                                                                                                                                                                                                                         | `true`                                    |
 | `agones.extensions.persistentLogsSizeLimitMB`            | Maximum total size of all Agones container logs in MB                                                                                                                                                                                                                                                            | `10000`                                   |
-| `agones.extensions.disableSecret`                        | Disables the creation of any allocator secrets. If true, you MUST provide the `{agones.releaseName}-cert` secrets before installation.                                                                                                                                                                           | `false`                                   |
+| `agones.extensions.disableSecret`                        | Disables the creation of any allocator secrets. If not set, this parameter falls back to the value of `.Values.agones.controller.disableSecret`. You MUST provide the `{agones.releaseName}-cert` secrets before installation if this is set to `true`.                                                                                                                                                                           | `false`                                   |


Can we please make a copy of this table with the changes and {{ feature }} shortcode it please.

The feature shortcode has been included in both the Controller and Extensions. If I remember correctly, you mentioned that this shortcode is only for the new features.🤔

site/content/en/docs/Installation/Install Agones/helm.md

…nsions

agones-bot · 2024-04-25T05:10:27Z

Build Succeeded 👏

Build Id: 704ca5a8-2c96-4826-93dd-7b9681c530ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://68a1ade-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3773/head:pr_3773 && git checkout pr_3773
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-68a1ade-amd64

zmerlynn · 2024-04-25T15:34:51Z

Looks pretty good to me.

@zmerlynn did you still want to talk about this PR?

Let's do it, I'm good.

agones-bot · 2024-04-25T17:09:42Z

Build Succeeded 👏

Build Id: d43cf526-c932-4f3a-8957-cbeb8410fc9b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://2a78148-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3773/head:pr_3773 && git checkout pr_3773
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-2a78148-amd64

agones-bot · 2024-05-01T22:05:40Z

Build Failed 😱

Build Id: 31fee705-e50d-4555-afa7-3cac36c8a6fd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-02T03:09:38Z

Build Succeeded 👏

Build Id: ec6cb5ee-af4d-45ef-aef6-90b86d1b3669

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://c622180-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3773/head:pr_3773 && git checkout pr_3773
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-c622180-amd64

Helm Parameter Migration to agones.extensions

33ddbcf

Kalaiselvi84 requested a review from markmandel April 17, 2024 15:52

github-actions bot added kind/other size/M labels Apr 17, 2024

Kalaiselvi84 added 2 commits April 17, 2024 16:43

Revert "Helm Parameter Migration to agones.extensions"

6629563

This reverts commit 33ddbcf.

apply default function to necessary .Values.agones.controller

2f3ed0d

github-actions bot added the size/S label Apr 17, 2024

Kalaiselvi84 added 2 commits April 17, 2024 17:41

modify helm.md to reflect the changes

af2cb5b

Merge branch 'main' into ac-to-ae

7d9caf7

Kalaiselvi84 changed the title ~~Helm Parameter Migration to agones.extensions~~ Helm Param Update: Default to agones.controller if agones.extensions is Missing Apr 17, 2024

zmerlynn mentioned this pull request Apr 18, 2024

Docs: remove unused specifications in cert-manager helm example #3735

Closed

default to agones.controller.pdb.maxUnavailable if agones.extensions.…

856975a

…pdb.maxUnavailable not set

zmerlynn reviewed Apr 19, 2024

View reviewed changes

site/content/en/docs/Installation/Install Agones/helm.md Outdated Show resolved Hide resolved

Kalaiselvi84 added 3 commits April 19, 2024 18:18

Revert "default to agones.controller.pdb.maxUnavailable if agones.ext…

4006c3f

…ensions.pdb.maxUnavailable not set" This reverts commit 856975a.

revert default for maxUnavailable and fix punctuation

160ca6c

Merge branch 'main' into ac-to-ae

34f0d64

zmerlynn approved these changes Apr 19, 2024

View reviewed changes

Merge branch 'main' into ac-to-ae

d529654

zmerlynn enabled auto-merge (squash) April 23, 2024 15:49

zmerlynn disabled auto-merge April 23, 2024 15:58

markmandel reviewed Apr 24, 2024

View reviewed changes

feature shortcode, deprecated info in controller, and cleaned up exte…

68a1ade

…nsions

Merge branch 'main' into ac-to-ae

2a78148

Merge branch 'main' into ac-to-ae

c622180

zmerlynn enabled auto-merge (squash) May 1, 2024 21:38

zmerlynn merged commit 2c10404 into googleforgames:main May 2, 2024
4 checks passed

Kalaiselvi84 added kind/bug These are bugs. and removed kind/other labels Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm Param Update: Default to agones.controller if agones.extensions is Missing #3773

Helm Param Update: Default to agones.controller if agones.extensions is Missing #3773

Kalaiselvi84 commented Apr 17, 2024

agones-bot commented Apr 17, 2024

Kalaiselvi84 commented Apr 17, 2024

agones-bot commented Apr 17, 2024

agones-bot commented Apr 17, 2024

zmerlynn commented Apr 18, 2024

agones-bot commented Apr 18, 2024

Kalaiselvi84 commented Apr 19, 2024

agones-bot commented Apr 19, 2024

zmerlynn left a comment

agones-bot commented Apr 23, 2024

markmandel left a comment

markmandel Apr 24, 2024

Kalaiselvi84 Apr 25, 2024

agones-bot commented Apr 25, 2024

zmerlynn commented Apr 25, 2024

agones-bot commented Apr 25, 2024

agones-bot commented May 1, 2024

agones-bot commented May 2, 2024

Helm Param Update: Default to agones.controller if agones.extensions is Missing #3773

Helm Param Update: Default to agones.controller if agones.extensions is Missing #3773

Conversation

Kalaiselvi84 commented Apr 17, 2024

agones-bot commented Apr 17, 2024

Kalaiselvi84 commented Apr 17, 2024

agones-bot commented Apr 17, 2024

agones-bot commented Apr 17, 2024

zmerlynn commented Apr 18, 2024

agones-bot commented Apr 18, 2024

Kalaiselvi84 commented Apr 19, 2024

agones-bot commented Apr 19, 2024

zmerlynn left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 23, 2024

markmandel left a comment

Choose a reason for hiding this comment

markmandel Apr 24, 2024

Choose a reason for hiding this comment

Kalaiselvi84 Apr 25, 2024

Choose a reason for hiding this comment

agones-bot commented Apr 25, 2024

zmerlynn commented Apr 25, 2024

agones-bot commented Apr 25, 2024

agones-bot commented May 1, 2024

agones-bot commented May 2, 2024