-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail CI if a PR updates an example without modifying the version #3794
Comments
@zmerlynn, The The following files can be ignored: Please let me know if I have included any files in the ignored list by mistakenly. |
I would tend towards to a denylist but make it less broad. In particular, things like In addition, if you want you can add to each of the version files (probably right above the version or on the same line?) a comment line |
Update: I'm working on this issue and have noticed that the script should ignore comments. I'm currently looking into this. |
…g the version Further to issue googleforgames#3794, if any files change within an example - outside of a simple denylist - and the version in its Makefile is not updated, this new tool will fail the CI pipeline.
Further to issue googleforgames#3794, if any files change within an example - outside of a simple denylist - and the version in its Makefile is not updated, this new tool will fail the CI pipeline.
Further to issue googleforgames#3794, if any files change within an example - outside of a simple denylist - and the version in its Makefile is not updated, this new tool will fail the CI pipeline.
Further to issue googleforgames#3794, if any files change within an example - outside of a simple denylist - and the version in its Makefile is not updated, this new tool will fail the CI pipeline
'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions ' |
This is being worked on, so bumping. |
If someone modifies anything in
examples/foo
, there should be a corresponding change to theversion :=
line in the Makefile. This should be easy to catch in CI. This would catch some of the common cases like #3793 (which should have been flagged), and also fail Dependabot PRs against examples/ early.If we want to get fancy, there's technically files like
README.md
that can be ignored in every directory.The text was updated successfully, but these errors were encountered: