Feature Stages Documentation #1080

markmandel · 2019-09-26T23:38:34Z

Feedback on below very much warranted and appreciated - from where it sits in the documentation, to the contents itself.

Definitions of feature stages, how they are enabled/disabled, the support to be expected at each stage, and how each stage can be identified.

Updates to the contributing guide as well, as this needs to be kept in mind for new features and design work.

Credit / Reference:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-stages
https://istio.io/about/feature-stages/#feature-phase-definitions

agones-bot · 2019-09-27T00:11:28Z

Build Succeeded 👏

Build Id: 3186bdc2-d8ba-4a6e-98d3-d3644951d968

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-a96d2ff
image: gcr.io/agones-images/agones-sdk:1.1.0-a96d2ff
image: gcr.io/agones-images/agones-ping:1.1.0-a96d2ff
Linux C++ SDK (build): agonessdk-1.1.0-a96d2ff-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-a96d2ff.zip

A preview of the website (the last 30 builds are retained):

https://a96d2ff-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-a96d2ff

pooneh-m

This looks really good. Thanks for putting it together. I just have a concern about versioning the SDK.

site/content/en/docs/Guides/feature-stages.md

roberthbailey

Kubernetes lists the specific features inline (on the page you linked to). Do you think it would be better to do that than just say "look through the helm configuration" or "read the feature gate documentation for the feature you care about"? Having a central place to see the various feature gates seems like it would be really nice.

CONTRIBUTING.md

site/content/en/docs/Guides/feature-stages.md

roberthbailey · 2019-10-01T08:17:21Z

/assign

site/content/en/docs/Guides/feature-stages.md

markmandel

Kubernetes lists the specific features inline (on the page you linked to). Do you think it would be better to do that than just say "look through the helm configuration" or "read the feature gate documentation for the feature you care about"? Having a central place to see the various feature gates seems like it would be really nice.

Yeah, I agree. I think I was just hesitant to maintain it. My thought was once something goes to stable, the gate gets removed. Whereas Kubernetes maintains the feature gate. Do you think we should do the same?

I'm updating the doc to include a section for the list of feature gates.

agones-bot · 2019-10-02T00:13:51Z

Build Succeeded 👏

Build Id: 303fd64e-17af-47e1-b027-f58f6ad53e11

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-6ff2597
image: gcr.io/agones-images/agones-sdk:1.1.0-6ff2597
image: gcr.io/agones-images/agones-ping:1.1.0-6ff2597
Linux C++ SDK (build): agonessdk-1.1.0-6ff2597-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-6ff2597.zip

A preview of the website (the last 30 builds are retained):

https://6ff2597-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-6ff2597

roberthbailey · 2019-10-02T05:18:37Z

I'm happy removing the gates (and their documentation) once they hit stable. I think having a list of things you can try right now makes sense and you should be able to tell which feature gates apply to your version of Agones using the drop down on the website that takes you to the version specific docs.

site/content/en/docs/Guides/feature-stages.md

markmandel

Made some updates. Also moving this out of draft, since I'm not sure what benefit that gives.

site/content/en/docs/Guides/feature-stages.md

agones-bot · 2019-10-24T00:43:07Z

Build Failed 😱

Build Id: 1e4de8ec-6777-4036-a28b-b6cafdf58198

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-24T00:59:31Z

Build Succeeded 👏

Build Id: e2b00070-9420-4208-9c0d-a6b1a19c4ad9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3da76b4
image: gcr.io/agones-images/agones-sdk:1.1.0-3da76b4
image: gcr.io/agones-images/agones-ping:1.1.0-3da76b4
Linux C++ SDK (build): agonessdk-1.1.0-3da76b4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3da76b4.zip

A preview of the website (the last 30 builds are retained):

https://3da76b4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3da76b4

markmandel · 2019-11-04T20:45:12Z

@roberthbailey @pooneh-m I think this is pretty close - I updated the gRPC section with a resolution from the research in #1043. PTAL, let me know what you think.

agones-bot · 2019-11-04T20:56:43Z

Build Succeeded 👏

Build Id: 34417e1f-02b1-4f53-bec9-901790c92497

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-3a537cb
image: gcr.io/agones-images/agones-sdk:1.2.0-3a537cb
image: gcr.io/agones-images/agones-ping:1.2.0-3a537cb
Linux C++ SDK (build): agonessdk-1.2.0-3a537cb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-3a537cb.zip

A preview of the website (the last 30 builds are retained):

https://3a537cb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-3a537cb

pooneh-m · 2019-11-04T21:03:53Z

site/content/en/docs/Guides/feature-stages.md

+For example, a REST API with a prefix of `v1alpha1` is an `alpha` stage feature: 
+`http://api.example.com/v1alpha1/exampleaction`.
+
+Similar to the SDK, Any `alpha` or `beta` gRPC functionality will be a subpackage of the main API package.


How about if there is a breaking change to the v1 API?

This is a good question. Ideally, we never want this to happen - since the SDK is so important -- but I may be being optimistic that it won't ever happen - or at least to the degree that we want a whole new implementation of the SDK.

I'm almost tempted to say "handle it if/when we need to?, and hopefully we won't have to?"

Oh wait, wrong section - this isn't the SDK section, this is the API section.

So my only concern here, is that if we do a v1/v2 type API surface, it's completely different from the SDK. Maybe that is fine though? I'd like to have consistency however.

WDYT?

Optimistically, I also expect major versioning would not happen However, it wouldn't hurt to mention that if there is any required incompatible change to the stable version there should be an extensive communication and planning.

This sounds like a great addition as well 👍

How strongly do you feed about having a v1/v2 interface/package for the gRPC/REST endpoints.

I'm thinking I might be backtracking on my position of not doing this - just because it's going to be really hard to go back and slot this in if we need it (SDK comes to mind).

I'm not a huge fan of packages called v1 (hello K8s), but I can't think of a better way.

Version in the package name for gRPC for v1 is optional.
For REST, I have always seen APIs to be versioned, but couldn't find a recommendation specific to v1 versioning. I would recommend designing REST API with version in the path to avoid URL changes between versions.

site/content/en/docs/Guides/feature-stages.md

pooneh-m · 2019-11-04T21:05:24Z

site/content/en/docs/Guides/feature-stages.md

+For example, a REST API with a prefix of `v1alpha1` is an `alpha` stage feature: 
+`http://api.example.com/v1alpha1/exampleaction`.
+
+Similar to the SDK, Any `alpha` or `beta` gRPC functionality will be a subpackage of the main API package.


We should perhaps mention that alpha/beta features are a super-set of the main package?

So you are saying all stable features should be available in the alpha/beta sdk subpackage?

So I should be able to do sdk.alphav1.Ready()?

If so, I'm not sure what the benefit would be?

So you are saying all stable features should be available in the alpha/beta sdk subpackage?

I think now I understand why you wanted to run two SDK packages side by side because one supports a none stable API and the other supports a stable API. If this is what you are recommending, please make it clear. Otherwise, I assumed an alpha API would be a super set of the stable API and there is only one SDK running. For example, if the SDK is going to support an alpha feature SelfNominate(), I thought I create a new snapshot of the SDK and version it as sdk.v1alpha1 which is a super set of sdk[.v1] package and expose it for experimentation.

Aaah! Yes! That is the disconnect. Yes, that is exactly the way I figured it would work, but I wasn't clear. Let me write words to that effect (it sounds like it will be similar to what we have in CRDs as well).

We can also do something like keep alpha/beta SDKs in place for a period after they move to stable, so that people have time to move over as well 👍

agones-bot · 2019-11-04T21:42:04Z

Build Succeeded 👏

Build Id: 1499d2dd-6b1e-4416-b7cb-18ab1750e6cf

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-41d4862
image: gcr.io/agones-images/agones-sdk:1.2.0-41d4862
image: gcr.io/agones-images/agones-ping:1.2.0-41d4862
Linux C++ SDK (build): agonessdk-1.2.0-41d4862-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-41d4862.zip

A preview of the website (the last 30 builds are retained):

https://41d4862-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-41d4862

agones-bot · 2019-11-05T00:45:21Z

Build Succeeded 👏

Build Id: 16d0f70d-61f3-488f-9eea-2e35a101735b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-9ecbecb
image: gcr.io/agones-images/agones-sdk:1.2.0-9ecbecb
image: gcr.io/agones-images/agones-ping:1.2.0-9ecbecb
Linux C++ SDK (build): agonessdk-1.2.0-9ecbecb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-9ecbecb.zip

A preview of the website (the last 30 builds are retained):

https://9ecbecb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-9ecbecb

roberthbailey · 2019-11-05T05:50:34Z

CONTRIBUTING.md

@@ -48,6 +48,16 @@ When submitting pull requests, make sure to do the following:
 - Remove trailing whitespace. Many editors will do this automatically.
 - Ensure any new files have [a trailing newline](https://stackoverflow.com/questions/5813311/no-newline-at-end-of-file)

+## Feature Stages


What would a breaking change in the controller look like?

roberthbailey · 2019-11-05T05:52:58Z

site/content/en/docs/Guides/feature-stages.md

+* The API may change in incompatible ways in a later software release without notice.
+* Recommended for use only in short-lived testing clusters, due to increased risk of bugs and lack of long-term support.
+
+> Note: Please do try `Alpha` features and give feedback on them. This is important to ensure less breaking changes


This (and below) should be switched to the new note style.

Nice. Good catch.

roberthbailey · 2019-11-05T05:58:17Z

site/content/en/docs/Guides/feature-stages.md

+
+As SDK features move to through feature stages towards `stable`, the previous version of the SDK API
+will remain for at least one release to enable easy migration to the more stable feature stage (i.e. from `alpha
+` -> `beta`, `beta` -> `alpha`)


Is this supposed to be beta -> stable?

roberthbailey · 2019-11-05T06:00:12Z

site/content/en/docs/Guides/feature-stages.md

+Any `alpha` or `beta` Game Server SDK functionality will be a subpackage of the `sdk` package. For example
+, functionality found in a `sdk.alphav1` package should be considered at the `alpha` feature stage.
+
+Only experimental functionality will be found in any `alpha` and `beta` SDK packages, and as such may change as 


This implies that you would import both the alpha and stable SDKs to start using the alpha sdk functions. I'm not actually sure how that would work in practice (do you have to call Connect twice?). Does the alpha package piggyback on the stable one somehow?

Yes, you would need to explicitly import the alpha package to use it. But I feel like from an implementation detail we would hide the gRPC details from the user.

From a gRPC technical details, I posted some details on how to do this technically on #1043

Aha, so I found the right stackoverflow post:
https://stackoverflow.com/questions/52634217/access-multiple-grpc-services-over-the-same-connection

This shows we can both register multiple services with the same endpoint, and also configure a singular connection with multiple clients - at least with Go.

Even if we end up having 2 connections to the same local endpoint, I don't think it's a drastic issue?

If we had alpha/betabe a superset ofstable`, would we demark a section of sdk.proto for alpha/beta functionality, and add/remove from there as needed? (and basically hide this from the user via our published SDK? This would have some complications for anyone generating a SDK, I would assume?)

Not to say I'm 100% against a superset, it was just my original viewpoint. I'm not completely married to the idea - maybe a superset is easier for us/the end user.

roberthbailey · 2019-11-05T06:00:42Z

site/content/en/docs/Guides/feature-stages.md

+
+### REST & gRPC APIs 
+
+REST and gRPC API will have versioned paths were appropriate to indicate their feature stage.


s/were/where

Definitions of feature stages, how they are enabled/disbaled, the support to be expected at each stage, and how each stage can be identified. Updates to the contributing guide as well, as this needs to be kept in mind for new features and design work. Credit / Reference: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-stages https://istio.io/about/feature-stages/#feature-phase-definitions

agones-bot · 2019-11-05T21:10:37Z

Build Failed 😱

Build Id: 6ecd9b16-5d67-48cf-926b-13ce6b7a08bc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-11-05T21:24:34Z

Build Succeeded 👏

Build Id: 532eed90-545e-42dc-b008-238d94c3e21d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-7f74cea
image: gcr.io/agones-images/agones-sdk:1.2.0-7f74cea
image: gcr.io/agones-images/agones-ping:1.2.0-7f74cea
Linux C++ SDK (build): agonessdk-1.2.0-7f74cea-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-7f74cea.zip

A preview of the website (the last 30 builds are retained):

https://7f74cea-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-7f74cea

markmandel · 2019-11-07T02:30:49Z

@pooneh-m @roberthbailey I'm almost wondering if we want to coordinate a video call and resolve this PR?

pooneh-m · 2019-11-07T06:12:48Z

@pooneh-m @roberthbailey I'm almost wondering if we want to coordinate a video call and resolve this PR?

It seems like the outstanding issue is the gRPC versioning. Should we consult with gRPC experts then to help making the decision? Other than that, LGTM.

markmandel · 2019-12-03T18:48:22Z

We have an internal gRPC office hours, I'm going to go tomorrow morning, and will get a resolution.

markmandel · 2019-12-04T18:52:52Z

Had a chat with the gRPC team:

Confirmed: On the server side, yes, you can register multiple proto defined services through a single gRPC ip and port (multiple registrations on a single server)
Confirmed: Client side, you can clients from multiple protos reuse the connection to that above single server from the same multiple protos. Some languages will share "channels", in others, if the client works out you are writing code to connect to the exact same place that the client already has a connection to - it will automatically reuse the TCP connection.

So I think we are good to go on the currently documented approach?

markmandel · 2019-12-12T23:51:29Z

Anything outstanding on this feature stage doc?

pooneh-m

LGTM. Thanks for double checking with gRPC experts.

google-oss-robot · 2019-12-13T00:00:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-12-13T00:04:57Z

New changes are detected. LGTM label has been removed.

markmandel · 2019-12-13T00:05:07Z

Oooh! Now we have to actually build the feature gate functionality 😄

agones-bot · 2019-12-13T00:18:13Z

Build Failed 😱

Build Id: 9825ce46-ee39-4da1-99c3-6d16cf323ad9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-12-13T00:31:30Z

--- FAIL: TestMultiClusterAllocationOnLocalCluster (0.44s)
    --- FAIL: TestMultiClusterAllocationOnLocalCluster/Packed (44.51s)
        gameserverallocation_test.go:80: Namespace gsa-multicluster-local-8a7d0c9d-1d3d-11ea-b2b9-0242c0a80a03 is created
        gameserverallocation_test.go:80: ServiceAccount gsa-multicluster-local-8a7d0c9d-1d3d-11ea-b2b9-0242c0a80a03/agones-sdk is created
        gameserverallocation_test.go:80: RoleBinding gsa-multicluster-local-8a7d0c9d-1d3d-11ea-b2b9-0242c0a80a03/agones-sdk-access is created
        gameserverallocation_test.go:182: 
            	Error Trace:	gameserverallocation_test.go:182
            	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"an error on the server (\"no multi-cluster allocation policy is specified\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)", Reason:"InternalError", Details:(*v1.StatusDetails)(0xc0008ac1e0), Code:500}}
            	Test:       	TestMultiClusterAllocationOnLocalCluster/Packed

That's a new one. @pooneh-m in case you know what's up here.

agones-bot · 2019-12-13T00:44:38Z

Build Succeeded 👏

Build Id: 5a1d114a-cc82-4f26-8e5b-41050d2a05c0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-6b0a07c
image: gcr.io/agones-images/agones-sdk:1.3.0-6b0a07c
image: gcr.io/agones-images/agones-ping:1.3.0-6b0a07c
Linux C++ SDK (build): agonessdk-1.3.0-6b0a07c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-6b0a07c.zip

A preview of the website (the last 30 builds are retained):

https://6b0a07c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1080/head:pr_1080 && git checkout pr_1080
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-6b0a07c

pooneh-m · 2019-12-13T00:48:48Z

--- FAIL: TestMultiClusterAllocationOnLocalCluster (0.44s)
    --- FAIL: TestMultiClusterAllocationOnLocalCluster/Packed (44.51s)
        gameserverallocation_test.go:80: Namespace gsa-multicluster-local-8a7d0c9d-1d3d-11ea-b2b9-0242c0a80a03 is created
        gameserverallocation_test.go:80: ServiceAccount gsa-multicluster-local-8a7d0c9d-1d3d-11ea-b2b9-0242c0a80a03/agones-sdk is created
        gameserverallocation_test.go:80: RoleBinding gsa-multicluster-local-8a7d0c9d-1d3d-11ea-b2b9-0242c0a80a03/agones-sdk-access is created
        gameserverallocation_test.go:182: 
            	Error Trace:	gameserverallocation_test.go:182
            	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"an error on the server (\"no multi-cluster allocation policy is specified\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)", Reason:"InternalError", Details:(*v1.StatusDetails)(0xc0008ac1e0), Code:500}}
            	Test:       	TestMultiClusterAllocationOnLocalCluster/Packed

That's a new one. @pooneh-m in case you know what's up here.

It's a flake. I opened #1114 while ago, but it didn't happen again. I'll reopen it to fix it. I think a retry will fix it.

Definitions of feature stages, how they are enabled/disbaled, the support to be expected at each stage, and how each stage can be identified. Updates to the contributing guide as well, as this needs to be kept in mind for new features and design work. Credit / Reference: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-stages https://istio.io/about/feature-stages/#feature-phase-definitions

markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones area/meta Organisational matters. e.g. Governance, release cycles, etc. labels Sep 26, 2019

google-oss-robot added do-not-merge/work-in-progress size/L labels Sep 26, 2019

pooneh-m reviewed Oct 1, 2019

View reviewed changes

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

roberthbailey reviewed Oct 1, 2019

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

site/content/en/docs/Guides/feature-stages.md Show resolved Hide resolved

site/content/en/docs/Guides/feature-stages.md Show resolved Hide resolved

site/content/en/docs/Guides/feature-stages.md Show resolved Hide resolved

google-oss-robot assigned roberthbailey Oct 1, 2019

aLekSer reviewed Oct 1, 2019

View reviewed changes

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

aLekSer reviewed Oct 1, 2019

View reviewed changes

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

markmandel commented Oct 1, 2019

View reviewed changes

markmandel force-pushed the meta/feature-stages branch from a96d2ff to 6ff2597 Compare October 1, 2019 23:47

roberthbailey reviewed Oct 2, 2019

View reviewed changes

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

markmandel mentioned this pull request Oct 23, 2019

SDK package should be versioned #1043

Closed

markmandel force-pushed the meta/feature-stages branch from 6ff2597 to c611c99 Compare October 24, 2019 00:34

google-oss-robot added the approved label Oct 24, 2019

markmandel commented Oct 24, 2019

View reviewed changes

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

site/content/en/docs/Guides/feature-stages.md Outdated Show resolved Hide resolved

markmandel marked this pull request as ready for review October 24, 2019 00:34

google-oss-robot removed the do-not-merge/work-in-progress label Oct 24, 2019

markmandel force-pushed the meta/feature-stages branch from c611c99 to 3da76b4 Compare October 24, 2019 00:45

markmandel force-pushed the meta/feature-stages branch from 3da76b4 to 3a537cb Compare November 4, 2019 20:43

pooneh-m reviewed Nov 4, 2019

View reviewed changes

markmandel force-pushed the meta/feature-stages branch from 41d4862 to 9ecbecb Compare November 5, 2019 00:31

roberthbailey reviewed Nov 5, 2019

View reviewed changes

markmandel force-pushed the meta/feature-stages branch from 9ecbecb to 7f74cea Compare November 5, 2019 20:55

pooneh-m approved these changes Dec 12, 2019

View reviewed changes

google-oss-robot assigned pooneh-m Dec 12, 2019

google-oss-robot added the lgtm label Dec 13, 2019

Merge branch 'master' into meta/feature-stages

6b0a07c

google-oss-robot removed the lgtm label Dec 13, 2019

markmandel merged commit eac79fa into googleforgames:master Dec 13, 2019

markmandel deleted the meta/feature-stages branch December 13, 2019 00:46

markmandel mentioned this pull request Dec 13, 2019

TestMultiClusterAllocationOnLocalCluster is flakey #1114

Closed

markmandel added this to the 1.3.0 milestone Jan 10, 2020


		### REST & gRPC APIs

		REST and gRPC API will have versioned paths were appropriate to indicate their feature stage.

Feature Stages Documentation #1080

Feature Stages Documentation #1080

Conversation

markmandel commented Sep 26, 2019 • edited Loading

agones-bot commented Sep 27, 2019

pooneh-m left a comment

Choose a reason for hiding this comment

roberthbailey left a comment

Choose a reason for hiding this comment

roberthbailey commented Oct 1, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 2, 2019

roberthbailey commented Oct 2, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 24, 2019

agones-bot commented Oct 24, 2019

markmandel commented Nov 4, 2019

agones-bot commented Nov 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pooneh-m Nov 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 4, 2019

agones-bot commented Nov 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Nov 5, 2019

agones-bot commented Nov 5, 2019

markmandel commented Nov 7, 2019

pooneh-m commented Nov 7, 2019

markmandel commented Dec 3, 2019

markmandel commented Dec 4, 2019

markmandel commented Dec 12, 2019

pooneh-m left a comment • edited Loading

Choose a reason for hiding this comment

google-oss-robot commented Dec 13, 2019

google-oss-robot commented Dec 13, 2019

markmandel commented Dec 13, 2019

agones-bot commented Dec 13, 2019

markmandel commented Dec 13, 2019

agones-bot commented Dec 13, 2019

pooneh-m commented Dec 13, 2019

markmandel commented Sep 26, 2019 •

edited

Loading

pooneh-m Nov 4, 2019 •

edited

Loading

pooneh-m left a comment •

edited

Loading