Add Go Client example which could create GS #1213

aLekSer · 2019-12-06T14:59:52Z

Add image and example job file which could be used as an example
provided by access-api document.

Closes #1212.

agones-bot · 2019-12-06T15:13:54Z

Build Succeeded 👏

Build Id: 70617dc8-b5f5-43d1-a5d6-c6f2ae8f1a83

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-012ddeb
image: gcr.io/agones-images/agones-sdk:1.2.0-012ddeb
image: gcr.io/agones-images/agones-ping:1.2.0-012ddeb
Linux C++ SDK (build): agonessdk-1.2.0-012ddeb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-012ddeb.zip

A preview of the website (the last 30 builds are retained):

https://012ddeb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-012ddeb

site/content/en/docs/Guides/access-api.md

markmandel · 2019-12-06T23:21:38Z

examples/crd-client/go.mod

+go 1.13
+
+require (
+	agones.dev/agones v1.1.0


Any thoughts on how we keep this up to date as we keep releasing Agones versions?

Should this now be 1.2.0 ?

markmandel

Coming back around to this - had a couple of small cleanup things.

Still not sure what to do with the hardcoded dependency on the previous versions of Agones as we keep doing releases. WDYT we should there? Just make sure we update it occasionally? (the agones.dev interface shouldn't change drastically from version to version?)

site/content/en/docs/Guides/access-api.md

markmandel · 2019-12-18T17:15:05Z

site/content/en/docs/Guides/access-api.md

@@ -108,6 +117,18 @@ func main() {
 	fmt.Printf("New game servers' name is: %s", newGS.ObjectMeta.Name)
 }
 ```
+{{% feature publishVersion="1.2.0" %}}


Same here, not sure if we need the feature shortcode here. It's not a new feature, just a new example. WDYT?

I am using {{< release-branch >}} in lines below, so batch.yaml file would not be accessible from 1.2 release branch

markmandel · 2019-12-18T17:15:18Z

examples/crd-client/go.mod

+go 1.13
+
+require (
+	agones.dev/agones v1.1.0


Should this now be 1.2.0 ?

agones-bot · 2019-12-20T15:03:45Z

Build Failed 😱

Build Id: f34e4685-e401-48f5-b1db-b2fe42723643

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-12-20T15:19:50Z

WDYT we should there? Just make sure we update it occasionally? (the agones.dev interface shouldn't change drastically from version to version?)

I think we can use latest there and also need to check that example image is in the registry.

agones-bot · 2019-12-20T15:28:54Z

Build Succeeded 👏

Build Id: d6a53e24-f367-48e8-9c40-22c2fbdd1d80

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-f0c199a
image: gcr.io/agones-images/agones-sdk:1.3.0-f0c199a
image: gcr.io/agones-images/agones-ping:1.3.0-f0c199a
Linux C++ SDK (build): agonessdk-1.3.0-f0c199a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-f0c199a.zip

A preview of the website (the last 30 builds are retained):

https://f0c199a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-f0c199a

aLekSer · 2019-12-20T15:44:13Z

Could not find an option to use latest version in go.mod. Anyway we definitely need to update

	k8s.io/apimachinery v0.0.0-20191004074956-01f8b7d1121a // kubernetes-1.13.12

and other project dependencies, otherwise we could not build the example client as in #1212.

agones-bot · 2019-12-20T15:52:21Z

Build Succeeded 👏

Build Id: 71840cb0-1ca9-45ff-87fd-2cbfb7a6fe05

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-690e8ce
image: gcr.io/agones-images/agones-sdk:1.3.0-690e8ce
image: gcr.io/agones-images/agones-ping:1.3.0-690e8ce
Linux C++ SDK (build): agonessdk-1.3.0-690e8ce-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-690e8ce.zip

A preview of the website (the last 30 builds are retained):

https://690e8ce-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-690e8ce

agones-bot · 2019-12-20T15:57:42Z

Build Succeeded 👏

Build Id: 51253337-4edd-41f5-b95e-093eeae78898

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-9c2343a
image: gcr.io/agones-images/agones-sdk:1.3.0-9c2343a
image: gcr.io/agones-images/agones-ping:1.3.0-9c2343a
Linux C++ SDK (build): agonessdk-1.3.0-9c2343a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-9c2343a.zip

A preview of the website (the last 30 builds are retained):

https://9c2343a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-9c2343a

agones-bot · 2019-12-20T16:04:53Z

Build Succeeded 👏

Build Id: 6fbe59d2-1265-4eef-b94f-0e39af310237

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-7274121
image: gcr.io/agones-images/agones-sdk:1.3.0-7274121
image: gcr.io/agones-images/agones-ping:1.3.0-7274121
Linux C++ SDK (build): agonessdk-1.3.0-7274121-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-7274121.zip

A preview of the website (the last 30 builds are retained):

https://7274121-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-7274121

agones-bot · 2019-12-21T00:26:23Z

Build Succeeded 👏

Build Id: 2af23366-cff0-401a-8984-f8871a1cb39b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-bb737eb
image: gcr.io/agones-images/agones-sdk:1.3.0-bb737eb
image: gcr.io/agones-images/agones-ping:1.3.0-bb737eb
Linux C++ SDK (build): agonessdk-1.3.0-bb737eb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-bb737eb.zip

A preview of the website (the last 30 builds are retained):

https://bb737eb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-bb737eb

agones-bot · 2019-12-21T08:50:08Z

Build Succeeded 👏

Build Id: f087f0ae-b5c4-44b2-bfa9-d1a201b93d88

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-74a795c
image: gcr.io/agones-images/agones-sdk:1.3.0-74a795c
image: gcr.io/agones-images/agones-ping:1.3.0-74a795c
Linux C++ SDK (build): agonessdk-1.3.0-74a795c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-74a795c.zip

A preview of the website (the last 30 builds are retained):

https://74a795c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-74a795c

markmandel · 2019-12-30T21:06:55Z

Looks good! Happy to commit, but would like to add one more small thing: Add this to the list of examples that are checked to make sure they exist in the registry when we do releases.

Need two things to add it:
Add an entry here of example-image-test.crd-client: https://github.com/googleforgames/agones/blob/master/build/includes/examples.mk#L29

Add a gcr-check in your Makefile for the example, you can copy the example here:
https://github.com/googleforgames/agones/blob/master/examples/simple-udp/Makefile#L45

Also, let me know if you would like me to build this and push it up to gcr.io for you.

markmandel · 2020-01-07T21:00:41Z

Gentle bump on this - would be good to have this in next week's RC release.

aLekSer · 2020-01-08T12:17:22Z

Also, let me know if you would like me to build this and push it up to gcr.io for you.

Yes, please, now we need to have this image in a registry.

agones-bot · 2020-01-08T12:27:06Z

Build Failed 😱

Build Id: 76d11d54-c59d-4141-8f55-e240401e2dd3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-01-08T12:43:01Z

Build failure:

Already have image (with digest): gcr.io/cloud-builders/gcloud
Services to deploy:

descriptor: [/workspace/go/src/site/.app.yaml]
source: [/workspace/go/src/site]
target project: [agones-images]
target service: [preview]
target version: [85fb57c]
target url: [https://85fb57c-dot-preview-dot-agones-images.appspot.com]


(add --promote if you also want to make this service available from
[https://preview-dot-agones-images.appspot.com])

Do you want to continue (Y/n)?
Beginning deployment of service [preview]...
#============================================================#
#= Uploading 86 files to Google Cloud Storage =#
#============================================================#
File upload done.
Updating service [preview]...
...........................................................................................................................................................................................................................................failed.
ERROR: (gcloud.app.deploy) Error Response: [13] Cloud build 106451eb-f18d-4bbc-bb13-063ab23a3d5b status: INTERNAL_ERROR.
Check the build log for errors: https://console.cloud.google.com/gcr/builds/106451eb-f18d-4bbc-bb13-063ab23a3d5b?project=258182270954
Build error details not available.

Add image and example job file which could be used as an example provided by access-api document.

agones-bot · 2020-01-08T17:34:59Z

Build Succeeded 👏

Build Id: 578455b0-e27e-46e8-8721-c471e947aeaf

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-44883ff
image: gcr.io/agones-images/agones-sdk:1.3.0-44883ff
image: gcr.io/agones-images/agones-ping:1.3.0-44883ff
Linux C++ SDK (build): agonessdk-1.3.0-44883ff-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-44883ff.zip

A preview of the website (the last 30 builds are retained):

https://44883ff-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-44883ff

agones-bot · 2020-01-08T17:39:56Z

Build Succeeded 👏

Build Id: 8eb53d02-229a-4ef7-8f79-3d75be71b3e2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-ea66f7d
image: gcr.io/agones-images/agones-sdk:1.3.0-ea66f7d
image: gcr.io/agones-images/agones-ping:1.3.0-ea66f7d
Linux C++ SDK (build): agonessdk-1.3.0-ea66f7d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-ea66f7d.zip

A preview of the website (the last 30 builds are retained):

https://ea66f7d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-ea66f7d

markmandel

👍

google-oss-robot · 2020-01-09T00:05:22Z

New changes are detected. LGTM label has been removed.

google-oss-robot · 2020-01-09T00:05:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-01-09T00:05:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-01-09T00:17:57Z

Build Succeeded 👏

Build Id: 9bd1f84c-63d7-4218-bb8a-47321b5615a4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-db4d3bf
image: gcr.io/agones-images/agones-sdk:1.3.0-db4d3bf
image: gcr.io/agones-images/agones-ping:1.3.0-db4d3bf
Linux C++ SDK (build): agonessdk-1.3.0-db4d3bf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-db4d3bf.zip

A preview of the website (the last 30 builds are retained):

https://db4d3bf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1213/head:pr_1213 && git checkout pr_1213
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-db4d3bf

markmandel · 2020-01-09T00:32:32Z

and pushed to gcr!

Add image and example job file which could be used as an example provided by access-api document. Co-authored-by: Mark Mandel <mark.mandel@gmail.com>

google-oss-robot added do-not-merge/work-in-progress size/L labels Dec 6, 2019

google-oss-robot requested review from dzlier-gcp and markmandel December 6, 2019 15:00

aLekSer mentioned this pull request Dec 6, 2019

devloping application to Access Agones via the Kubernetes API with compile error #1212

Closed

markmandel reviewed Dec 6, 2019

View reviewed changes

markmandel reviewed Dec 18, 2019

View reviewed changes

aLekSer force-pushed the example/client-set branch from 012ddeb to 5390eea Compare December 20, 2019 14:50

aLekSer force-pushed the example/client-set branch from 5390eea to f0c199a Compare December 20, 2019 15:15

aLekSer force-pushed the example/client-set branch from f0c199a to 690e8ce Compare December 20, 2019 15:39

google-oss-robot added size/XL and removed size/L labels Dec 20, 2019

aLekSer force-pushed the example/client-set branch from 690e8ce to 9c2343a Compare December 20, 2019 15:39

aLekSer force-pushed the example/client-set branch from 9c2343a to 7274121 Compare December 20, 2019 15:51

aLekSer marked this pull request as ready for review December 20, 2019 15:53

google-oss-robot removed the do-not-merge/work-in-progress label Dec 20, 2019

aLekSer force-pushed the example/client-set branch from 7274121 to bb737eb Compare December 21, 2019 00:05

aLekSer force-pushed the example/client-set branch from bb737eb to 74a795c Compare December 21, 2019 08:37

aLekSer force-pushed the example/client-set branch from 74a795c to 85fb57c Compare January 8, 2020 12:16

aLekSer force-pushed the example/client-set branch from 85fb57c to ea66f7d Compare January 8, 2020 17:13

Add Go Client example which could create GS

44883ff

Add image and example job file which could be used as an example provided by access-api document.

aLekSer force-pushed the example/client-set branch from ea66f7d to 44883ff Compare January 8, 2020 17:15

markmandel approved these changes Jan 9, 2020

View reviewed changes

google-oss-robot assigned markmandel Jan 9, 2020

google-oss-robot added the lgtm label Jan 9, 2020

Merge branch 'master' into example/client-set

db4d3bf

google-oss-robot removed the lgtm label Jan 9, 2020

google-oss-robot added the approved label Jan 9, 2020

markmandel merged commit 2d0ec1d into googleforgames:master Jan 9, 2020

markmandel added area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones labels Jan 9, 2020

markmandel added this to the 1.3.0 milestone Jan 10, 2020

aLekSer deleted the example/client-set branch January 13, 2020 15:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Go Client example which could create GS #1213

Add Go Client example which could create GS #1213

aLekSer commented Dec 6, 2019

agones-bot commented Dec 6, 2019

markmandel Dec 6, 2019

markmandel Dec 18, 2019

markmandel left a comment

markmandel Dec 18, 2019

aLekSer Dec 20, 2019 •

edited

Loading

markmandel Dec 18, 2019

agones-bot commented Dec 20, 2019

aLekSer commented Dec 20, 2019

agones-bot commented Dec 20, 2019

aLekSer commented Dec 20, 2019 •

edited

Loading

agones-bot commented Dec 20, 2019

agones-bot commented Dec 20, 2019

agones-bot commented Dec 20, 2019

agones-bot commented Dec 21, 2019

agones-bot commented Dec 21, 2019

markmandel commented Dec 30, 2019

markmandel commented Jan 7, 2020

aLekSer commented Jan 8, 2020

agones-bot commented Jan 8, 2020

aLekSer commented Jan 8, 2020

agones-bot commented Jan 8, 2020

agones-bot commented Jan 8, 2020

markmandel left a comment

google-oss-robot commented Jan 9, 2020

google-oss-robot commented Jan 9, 2020

google-oss-robot commented Jan 9, 2020

agones-bot commented Jan 9, 2020

markmandel commented Jan 9, 2020

Add Go Client example which could create GS #1213

Add Go Client example which could create GS #1213

Conversation

aLekSer commented Dec 6, 2019

agones-bot commented Dec 6, 2019

markmandel Dec 6, 2019

Choose a reason for hiding this comment

markmandel Dec 18, 2019

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

markmandel Dec 18, 2019

Choose a reason for hiding this comment

aLekSer Dec 20, 2019 • edited Loading

Choose a reason for hiding this comment

markmandel Dec 18, 2019

Choose a reason for hiding this comment

agones-bot commented Dec 20, 2019

aLekSer commented Dec 20, 2019

agones-bot commented Dec 20, 2019

aLekSer commented Dec 20, 2019 • edited Loading

agones-bot commented Dec 20, 2019

agones-bot commented Dec 20, 2019

agones-bot commented Dec 20, 2019

agones-bot commented Dec 21, 2019

agones-bot commented Dec 21, 2019

markmandel commented Dec 30, 2019

markmandel commented Jan 7, 2020

aLekSer commented Jan 8, 2020

agones-bot commented Jan 8, 2020

aLekSer commented Jan 8, 2020

agones-bot commented Jan 8, 2020

agones-bot commented Jan 8, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jan 9, 2020

google-oss-robot commented Jan 9, 2020

google-oss-robot commented Jan 9, 2020

agones-bot commented Jan 9, 2020

markmandel commented Jan 9, 2020

aLekSer Dec 20, 2019 •

edited

Loading

aLekSer commented Dec 20, 2019 •

edited

Loading