Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message for Health Check Failure #1222

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Better error message for Health Check Failure #1222

merged 2 commits into from
Dec 19, 2019

Conversation

markmandel
Copy link
Member

Includes more e2e and unit tests to cover this scenario.

Should improve experience in #1217

@markmandel
Better error message for Health Check Failure
2c311a6 
Includes more e2e and unit tests to cover
this scenario.

Should improve experience in googleforgames#1217
@markmandel markmandel added kind/feature New features for Agones feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) area/operations Installation, updating, metrics etc labels Dec 10, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c222cc38-ebe8-40b0-b6c2-561a74cb8a6c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1222/head:pr_1222 && git checkout pr_1222
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-2c311a6

@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Dec 12, 2019
@markmandel markmandel marked this pull request as ready for review December 12, 2019 00:33
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fb25891f-36d9-4713-92f0-57bf589e5fb6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1222/head:pr_1222 && git checkout pr_1222
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-994316a

@roberthbailey roberthbailey merged commit 1161b40 into googleforgames:master Dec 19, 2019
@markmandel markmandel added this to the 1.3.0 milestone Dec 19, 2019
@markmandel markmandel deleted the feature/better-unhealthy branch December 19, 2019 22:51
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Better error message for Health Check Failure (googleforgames#1222)
b9f715b 
Includes more e2e and unit tests to cover
this scenario.

Should improve experience in googleforgames#1217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/operations Installation, updating, metrics etc kind/feature New features for Agones size/M
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey