Unity SDK - Watch GameServer Functionality #1234

markmandel · 2019-12-13T23:12:07Z

Able to use the DownloadHandlerScript to intercept streaming HTTP data from the /watch/gameserver REST endpoint.

This finishes the feature work for Unity on #927

markmandel · 2019-12-13T23:12:32Z

/assign @dzlier-gcp @pooneh-m

Please review 😄

agones-bot · 2019-12-13T23:27:01Z

Build Succeeded 👏

Build Id: f097105f-503f-4b35-86c1-b4d4d1088079

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-5c6c28e
image: gcr.io/agones-images/agones-sdk:1.3.0-5c6c28e
image: gcr.io/agones-images/agones-ping:1.3.0-5c6c28e
Linux C++ SDK (build): agonessdk-1.3.0-5c6c28e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-5c6c28e.zip

A preview of the website (the last 30 builds are retained):

https://5c6c28e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1234/head:pr_1234 && git checkout pr_1234
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-5c6c28e

pooneh-m · 2019-12-17T07:32:36Z

sdks/unity/AgonesSdk.cs

+            protected override bool ReceiveData(byte[] data, int dataLength)
+            {
+                string json = Encoding.UTF8.GetString(data);
+                var dictionary = (Dictionary<string, object>) Json.Deserialize(json);


can the data contain invalid json?

If it did, it would be Exceptional.

🤣

pooneh-m · 2019-12-17T07:38:51Z

sdks/unity/AgonesSdk.cs

+            {
+                string json = Encoding.UTF8.GetString(data);
+                var dictionary = (Dictionary<string, object>) Json.Deserialize(json);
+                var gameServer = new GameServer(dictionary["result"] as Dictionary<string, object>);


Check to verify "result" key exists in the dictionary?

If it doesn't, you will end up with an empty non-populated GameServer.

Should we throw an Exception if it didn't work as expected?

if result is not in the dictionary, an exception will be thrown:
[System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.] at System.Collections.Generic.Dictionary.get_Item(TKey key)

If you want a non-populated GS, you should handle this with if dictionary.Contains("result")...

Hmnn. Actually I don't mind if the exception occurs. It's probably a better indicator that something went horribly wrong, rather than giving a non-populated GS.

So I'm going to go with "works as intended" 👍 (unless you have an objection?)

Appreciate the explanations!

The exception is hard to debug without more details. However, if it is intended, LGTM.

pooneh-m · 2019-12-17T07:42:56Z

examples/unity-simple/Assets/Scripts/UdpEchoServer.cs

                            echoBytes = Encoding.UTF8.GetBytes($"Reserve({recvTexts[1]}) {ok}");
                        }
                        else
                        {
                            echoBytes = Encoding.UTF8.GetBytes($"ERROR: Invalid Reserve command, must use 1 argument");
                        }
                        break;
+                    case "Watch":
+                        agones.WatchGameServer(gameServer => { Debug.Log($"Server - Watch {gameServer}"); });


I think you can drop parenthesis x => {y;} --> x => y

agones-bot · 2019-12-18T01:15:52Z

Build Succeeded 👏

Build Id: 2147d491-729b-4b9a-9c7f-c8a7a6509db2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-35f9017
image: gcr.io/agones-images/agones-sdk:1.3.0-35f9017
image: gcr.io/agones-images/agones-ping:1.3.0-35f9017
Linux C++ SDK (build): agonessdk-1.3.0-35f9017-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-35f9017.zip

A preview of the website (the last 30 builds are retained):

https://35f9017-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1234/head:pr_1234 && git checkout pr_1234
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-35f9017

dzlier-gcp · 2019-12-18T18:31:38Z

Just noting that I have seen this - will review before EOW

pooneh-m · 2019-12-18T23:59:58Z

sdks/unity/AgonesSdk.cs

+            {
+                string json = Encoding.UTF8.GetString(data);
+                var dictionary = (Dictionary<string, object>) Json.Deserialize(json);
+                var gameServer = new GameServer(dictionary["result"] as Dictionary<string, object>);


if result is not in the dictionary, an exception will be thrown:
[System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.] at System.Collections.Generic.Dictionary.get_Item(TKey key)

If you want a non-populated GS, you should handle this with if dictionary.Contains("result")...

pooneh-m · 2019-12-19T00:00:39Z

site/content/en/docs/Guides/Client SDKs/unity.md

+configuration changes.
+
+```csharp
+agones.WatchGameServer(gameServer => { Debug.Log($"Server - Watch {gameServer}"); });


x => {y;} to x => y here as well?

Doh! Nice pickup. Will change!

Able to use the `DownloadHandlerScript` to intercept streaming HTTP data from the /watch/gameserver REST endpoint. This finishes the feature work for Unity on googleforgames#927

google-oss-robot · 2019-12-19T22:59:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2019-12-19T23:05:29Z

Build Succeeded 👏

Build Id: a37eade6-805f-409d-baee-4426243e3a98

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-222abf0
image: gcr.io/agones-images/agones-sdk:1.3.0-222abf0
image: gcr.io/agones-images/agones-ping:1.3.0-222abf0
Linux C++ SDK (build): agonessdk-1.3.0-222abf0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-222abf0.zip

A preview of the website (the last 30 builds are retained):

https://222abf0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1234/head:pr_1234 && git checkout pr_1234
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-222abf0

markmandel · 2020-01-07T20:38:53Z

I somehow missed this was Approved. Getting it merged!

google-oss-robot · 2020-01-07T20:39:01Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-01-07T20:52:54Z

Build Succeeded 👏

Build Id: 9b135153-5fc6-48ae-8736-c0ecc2b11446

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-ebe25b6
image: gcr.io/agones-images/agones-sdk:1.3.0-ebe25b6
image: gcr.io/agones-images/agones-ping:1.3.0-ebe25b6
Linux C++ SDK (build): agonessdk-1.3.0-ebe25b6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-ebe25b6.zip

A preview of the website (the last 30 builds are retained):

https://ebe25b6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1234/head:pr_1234 && git checkout pr_1234
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-ebe25b6

Able to use the `DownloadHandlerScript` to intercept streaming HTTP data from the /watch/gameserver REST endpoint. This finishes the feature work for Unity on googleforgames#927

markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Dec 13, 2019

google-oss-robot added the size/M label Dec 13, 2019

google-oss-robot requested review from EricFortin and roberthbailey December 13, 2019 23:12

google-oss-robot added the approved label Dec 13, 2019

google-oss-robot assigned dzlier-gcp and pooneh-m Dec 13, 2019

roberthbailey requested review from pooneh-m and dzlier-gcp and removed request for EricFortin and roberthbailey December 13, 2019 23:19

pooneh-m reviewed Dec 17, 2019

View reviewed changes

markmandel mentioned this pull request Dec 18, 2019

Swagger: WatchGameServer() definition is not generated properly in sdk.swagger.json #1106

Closed

markmandel force-pushed the feature/unity-watch branch from 5c6c28e to 35f9017 Compare December 18, 2019 01:02

pooneh-m reviewed Dec 19, 2019

View reviewed changes

Unity SDK - Watch GameServer Functionality

222abf0

Able to use the `DownloadHandlerScript` to intercept streaming HTTP data from the /watch/gameserver REST endpoint. This finishes the feature work for Unity on googleforgames#927

markmandel force-pushed the feature/unity-watch branch from 35f9017 to 222abf0 Compare December 19, 2019 22:51

pooneh-m approved these changes Dec 19, 2019

View reviewed changes

google-oss-robot added the lgtm label Dec 19, 2019

Merge branch 'master' into feature/unity-watch

ebe25b6

google-oss-robot removed the lgtm label Jan 7, 2020

markmandel merged commit 8d383b6 into googleforgames:master Jan 7, 2020

markmandel deleted the feature/unity-watch branch January 7, 2020 20:53

markmandel added this to the 1.3.0 milestone Jan 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unity SDK - Watch GameServer Functionality #1234

Unity SDK - Watch GameServer Functionality #1234

markmandel commented Dec 13, 2019

markmandel commented Dec 13, 2019

agones-bot commented Dec 13, 2019

pooneh-m Dec 17, 2019

markmandel Dec 18, 2019

pooneh-m Dec 17, 2019

markmandel Dec 18, 2019

pooneh-m Dec 18, 2019 •

edited

Loading

markmandel Dec 19, 2019

pooneh-m Dec 19, 2019

pooneh-m Dec 17, 2019

agones-bot commented Dec 18, 2019

dzlier-gcp commented Dec 18, 2019

pooneh-m Dec 18, 2019 •

edited

Loading

pooneh-m Dec 19, 2019

markmandel Dec 19, 2019

google-oss-robot commented Dec 19, 2019

agones-bot commented Dec 19, 2019

markmandel commented Jan 7, 2020

google-oss-robot commented Jan 7, 2020

agones-bot commented Jan 7, 2020

Unity SDK - Watch GameServer Functionality #1234

Unity SDK - Watch GameServer Functionality #1234

Conversation

markmandel commented Dec 13, 2019

markmandel commented Dec 13, 2019

agones-bot commented Dec 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pooneh-m Dec 18, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Dec 18, 2019

dzlier-gcp commented Dec 18, 2019

pooneh-m Dec 18, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-oss-robot commented Dec 19, 2019

agones-bot commented Dec 19, 2019

markmandel commented Jan 7, 2020

google-oss-robot commented Jan 7, 2020

agones-bot commented Jan 7, 2020

pooneh-m Dec 18, 2019 •

edited

Loading

pooneh-m Dec 18, 2019 •

edited

Loading