Node packaging #1264

rorygarand · 2020-01-08T03:34:36Z

Adds a publish script to send the node sdk to the github package registry.

Related to: #679.

agones-bot · 2020-01-08T03:47:07Z

Build Failed 😱

Build Id: e89aff76-2ecf-46b2-8937-1034bc16c187

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

steven-supersolid · 2020-01-08T15:46:05Z

build/build-sdk-images/node/publish.sh

+
+cd $AGONES_PATH/sdks/nodejs
+
+npm version $RELEASE_VERSION


How/when does this script get run?

I think updating the version number should be a careful change and follow semver, so potentially even a manual step. Or are these variables automatically populated and the aim is to keep the package version the same as the release version? If that is the case then what will happen when there are no SDK changes and how do we still comply with semver?

OK I've read #679 . Perhaps best to first focus on the publishing part and ensure it works and can look at again if we want to do version sync?

I'm happy to remove the version update. i was going to handle the release part - sounds like a check in the release checklist that we update the version (we can do this by hand?) would work.

So for this PR, we could drop the npm version $RELEASE_VERSION command?

Correct. I only added that as a potential way to address an earlier comment from you @markmandel.

@steven-supersolid I believe the idea is to run this from release.mk but I was going to leave that part to Mark.

Looks good and it seems we keep the SDK version the same as the Agones version?

That was the intent... I took out the npm version command for now though, we can always add it later if we want.

markmandel · 2020-01-08T19:15:09Z

Ah, this did actually break a thing!

We have a SDK test here:
https://github.com/markmandel/agones/blob/master/test/sdk/nodejs/testSDKClient.js#L15

So we'll need to change the name there in this PR too for it to pass.

We'll also need to update the nodejs example:
https://github.com/googleforgames/agones/blob/master/examples/nodejs-simple/src/index.js#L15

So it's worth noting this is a breaking change, just because the package name has changed.

Finally, we'll also need to update the documentation:
https://github.com/googleforgames/agones/blob/master/site/content/en/docs/Guides/Client%20SDKs/nodejs.md

(See https://agones.dev/site/docs/contribute/#within-a-page on how to have version specific documentation)

rorygarand · 2020-01-08T20:47:15Z

I was planning on updating the docs, is this PR the best place to do it?

Also, I'll add a fix to the test and remove the npm version command.

markmandel · 2020-01-08T20:49:45Z

Yep this PR will be the perfect place - we love having it all in one spot.

…into node-packaging

agones-bot · 2020-01-09T04:13:06Z

Build Failed 😱

Build Id: aa70138b-37b4-4129-b69f-2b33c3c800f9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-01-10T00:00:43Z

> @ testSDK /go/src/agones.dev/agones/test/sdk/nodejs
> node ./testSDKClient.js

internal/modules/cjs/loader.js:670
    throw err;
    ^

Error: Cannot find module '@googleforgames/agones'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:668:15)
    at Function.Module._load (internal/modules/cjs/loader.js:591:27)
    at Module.require (internal/modules/cjs/loader.js:723:19)
    at require (internal/modules/cjs/helpers.js:14:16)
    at Object.<anonymous> (/go/src/agones.dev/agones/test/sdk/nodejs/testSDKClient.js:15:19)
    at Module._compile (internal/modules/cjs/loader.js:816:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:827:10)
    at Module.load (internal/modules/cjs/loader.js:685:32)
    at Function.Module._load (internal/modules/cjs/loader.js:620:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:877:12)

Not sure how to solve these problems, but figured I'd find the relevant error message for you.

Let me know if you need help running this test locally.

steven-supersolid · 2020-01-10T10:14:20Z

Oh it won't work until published but we shouldn't publish until the tests all pass :) There is however another way for local testing using npm link.
From the test sdk folder run npm link <relative path to sdk> - this could be added to the script. Please note it will change package-lock.json but any changes can be discarded
https://docs.npmjs.com/cli/link.html

rorygarand

Yes, a bit of a catch 22. I was puzzling over the best approach to fix this.

I'll give your suggestion a try and see if that fixes the problem.

agones-bot · 2020-01-10T16:26:03Z

Build Succeeded 👏

Build Id: 994394b2-9682-48e9-ad16-5855113ceee8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-35f65b7
image: gcr.io/agones-images/agones-sdk:1.3.0-35f65b7
image: gcr.io/agones-images/agones-ping:1.3.0-35f65b7
Linux C++ SDK (build): agonessdk-1.3.0-35f65b7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-35f65b7.zip

A preview of the website (the last 30 builds are retained):

https://35f65b7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1264/head:pr_1264 && git checkout pr_1264
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-35f65b7

markmandel · 2020-01-10T23:14:58Z

Passing now! This LGTM - @steven-supersolid any issues on your end, or can I approve and merge?

steven-supersolid · 2020-01-13T10:07:48Z

Oh I thought I already approved. LGTM

markmandel

Oh I thought I already approved. LGTM

Yep, just wanted to double check with the changes. LGTM!

google-oss-robot · 2020-01-13T19:01:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, rorygarand, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-01-13T19:01:40Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-01-13T19:15:54Z

Build Succeeded 👏

Build Id: 01b7fe2d-33d7-4145-98f7-12ec12a82ee2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.3.0-0eee135
image: gcr.io/agones-images/agones-sdk:1.3.0-0eee135
image: gcr.io/agones-images/agones-ping:1.3.0-0eee135
Linux C++ SDK (build): agonessdk-1.3.0-0eee135-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.3.0-0eee135.zip

A preview of the website (the last 30 builds are retained):

https://0eee135-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1264/head:pr_1264 && git checkout pr_1264
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-0eee135

Adds a publish script to send the node sdk to the github package registry. Related to: googleforgames#679. Co-authored-by: Mark Mandel <mark.mandel@gmail.com>

rorygarand added 9 commits January 4, 2020 22:44

update version

1a3e7a9

use scoped name

57fb859

set registry location

9025357

update package version

92be813

add auth token

1cbe481

add node package target

063b80f

remove npm publishing

bf827ce

add npm publishing

9866b11

remove token

eb110f4

google-oss-robot added the size/M label Jan 8, 2020

google-oss-robot requested review from EricFortin and steven-supersolid January 8, 2020 03:34

Merge branch 'master' into node-packaging

20ea441

steven-supersolid reviewed Jan 8, 2020

View reviewed changes

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/breaking Breaking change kind/feature New features for Agones labels Jan 8, 2020

rorygarand added 6 commits January 8, 2020 21:41

limit scope to publishing only

f094384

import correct agones sdk

72823a7

change agones package dep

ed42356

import correct agones package

6d32363

update installation instructions

59c2f37

Merge branch 'node-packaging' of https://github.com/rorygarand/agones …

7cc33fa

…into node-packaging

roberthbailey removed the request for review from EricFortin January 9, 2020 05:57

roberthbailey assigned markmandel Jan 9, 2020

roberthbailey assigned steven-supersolid Jan 9, 2020

steven-supersolid approved these changes Jan 9, 2020

View reviewed changes

google-oss-robot added the lgtm label Jan 9, 2020

rorygarand commented Jan 10, 2020

View reviewed changes

use scoped package name

35f65b7

google-oss-robot removed the lgtm label Jan 10, 2020

markmandel approved these changes Jan 13, 2020

View reviewed changes

google-oss-robot added the lgtm label Jan 13, 2020

Merge branch 'master' into node-packaging

0eee135

google-oss-robot added approved and removed lgtm labels Jan 13, 2020

markmandel merged commit d30a4c0 into googleforgames:master Jan 13, 2020

markmandel added this to the 1.3.0 milestone Jan 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node packaging #1264

Node packaging #1264

rorygarand commented Jan 8, 2020

agones-bot commented Jan 8, 2020

steven-supersolid Jan 8, 2020

steven-supersolid Jan 8, 2020

markmandel Jan 8, 2020

rorygarand Jan 8, 2020

steven-supersolid Jan 9, 2020

rorygarand Jan 10, 2020

markmandel commented Jan 8, 2020 •

edited

Loading

rorygarand commented Jan 8, 2020

markmandel commented Jan 8, 2020

agones-bot commented Jan 9, 2020

markmandel commented Jan 10, 2020

steven-supersolid commented Jan 10, 2020

rorygarand left a comment

agones-bot commented Jan 10, 2020

markmandel commented Jan 10, 2020

steven-supersolid commented Jan 13, 2020

markmandel left a comment

google-oss-robot commented Jan 13, 2020

google-oss-robot commented Jan 13, 2020

agones-bot commented Jan 13, 2020

Node packaging #1264

Node packaging #1264

Conversation

rorygarand commented Jan 8, 2020

agones-bot commented Jan 8, 2020

steven-supersolid Jan 8, 2020

Choose a reason for hiding this comment

steven-supersolid Jan 8, 2020

Choose a reason for hiding this comment

markmandel Jan 8, 2020

Choose a reason for hiding this comment

rorygarand Jan 8, 2020

Choose a reason for hiding this comment

steven-supersolid Jan 9, 2020

Choose a reason for hiding this comment

rorygarand Jan 10, 2020

Choose a reason for hiding this comment

markmandel commented Jan 8, 2020 • edited Loading

rorygarand commented Jan 8, 2020

markmandel commented Jan 8, 2020

agones-bot commented Jan 9, 2020

markmandel commented Jan 10, 2020

steven-supersolid commented Jan 10, 2020

rorygarand left a comment

Choose a reason for hiding this comment

agones-bot commented Jan 10, 2020

markmandel commented Jan 10, 2020

steven-supersolid commented Jan 13, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jan 13, 2020

google-oss-robot commented Jan 13, 2020

agones-bot commented Jan 13, 2020

markmandel commented Jan 8, 2020 •

edited

Loading