Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzz Roundtrip test for v1 Agones schemas #1269

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fuzz Roundtrip test for v1 Agones schemas #1269

merged 1 commit into from
Jan 14, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jan 13, 2020 •
edited
Loading

Add Roundtrip tests for agones.dev external types.
Skip multicluster v1alpha1 API schema for now.
For #1098 .

@aLekSer aLekSer changed the title Example fuzz Roundtrip test Fuzz Roundtrip test for agones schemas Jan 13, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1d00a1a6-e497-4f22-9559-739d25426616

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer aLekSer force-pushed the fuzz-testing branch 2 times, most recently from 14e0aae to 9bbbbac Compare January 14, 2020 08:11
@aLekSer
Copy link
Collaborator Author

aLekSer commented Jan 14, 2020 •
edited
Loading

I have removed Multicluster v1alpha1 IP which causes test fail "agones.dev/agones/pkg/apis/multicluster/v1alpha1"
We can add this API into a separate test with t.Skip() initially.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 235b3d05-4c91-40f8-858f-b4e58c3b8b55

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a302c786-f6c8-4266-b0ff-60bd1dbbd78e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1269/head:pr_1269 && git checkout pr_1269
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-14e0aae

@aLekSer
Example fuzz Roundtrip test
51799ae 
Add Roundtrip tests for agones.dev external types.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b0c50dfa-624e-4040-98c8-707571939f16

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1269/head:pr_1269 && git checkout pr_1269
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.3.0-51799ae

@aLekSer aLekSer marked this pull request as ready for review January 14, 2020 08:42
@aLekSer aLekSer changed the title Fuzz Roundtrip test for agones schemas Fuzz Roundtrip test for v1 Agones schemas Jan 14, 2020
@roberthbailey roberthbailey merged commit 577b7e1 into googleforgames:master Jan 14, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.3.0 milestone Jan 14, 2020
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones labels Jan 14, 2020
@roberthbailey roberthbailey mentioned this pull request Jan 30, 2020
Merged
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Example fuzz Roundtrip test (googleforgames#1269)
8efaf05 
Add Roundtrip tests for agones.dev external types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @google-oss-robot @roberthbailey @markmandel