Stubs for SDK alpha/beta/stable functionality #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/feature
|
Build Failed 😱 Build Id: 043ebab9-cee5-495a-904a-3a64cbd5f4b4 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 8fa4e79f-1684-459a-adc4-ed1f2f885329 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 43aa0c42-f801-479c-bfcb-4206853b1952 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
force-pushed
the
cleanup/move-sdk-proto
branch
from
e071d56 to
bd1dc7a
Compare
|
Build Failed 😱 Build Id: cada99e9-e464-45e3-a4e2-18c3bab6b4b3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 0dfe18ca-1e84-40f6-a0e2-6bad4d03023c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This gets the requisite pieces in place, such that alpha and beta features can be written for the GameServer SDKs. This includes: - Moving the sdk.proto into the proto directory - Updating all the gen scripts for clients for the new sdk.proto location - creating new alpha.proto and beta.proto definitions, with an empty service stub - Integrated the new alpha and beta service stubs into the sdkserver local and sidecar implementations. - Moved all the swagger generated files under ./sdks/swagger (felt like an appropriate place) I've deliberately not update all the clients as (a) I felt it would make this PR too big and (b) each language's client may have slightly different integration requirements. I figured it could be handled on a case by case basis, as required.
markmandel
force-pushed
the
cleanup/move-sdk-proto
branch
from
bd1dc7a to
e57994f
Compare
|
Build Succeeded 👏 Build Id: ed82a404-7dc5-404e-9d70-d7f2897ce6a4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
approved these changes
Jan 29, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Jan 29, 2020
This gets the requisite pieces in place, such that alpha and beta features can be written for the GameServer SDKs. This includes: - Moving the sdk.proto into the proto directory - Updating all the gen scripts for clients for the new sdk.proto location - creating new alpha.proto and beta.proto definitions, with an empty service stub - Integrated the new alpha and beta service stubs into the sdkserver local and sidecar implementations. - Moved all the swagger generated files under ./sdks/swagger (felt like an appropriate place) I've deliberately not update all the clients as (a) I felt it would make this PR too big and (b) each language's client may have slightly different integration requirements. I figured it could be handled on a case by case basis, as required.
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Jan 29, 2020
This gets the requisite pieces in place, such that alpha and beta features can be written for the GameServer SDKs. This includes: - Moving the sdk.proto into the proto directory - Updating all the gen scripts for clients for the new sdk.proto location - creating new alpha.proto and beta.proto definitions, with an empty service stub - Integrated the new alpha and beta service stubs into the sdkserver local and sidecar implementations. - Moved all the swagger generated files under ./sdks/swagger (felt like an appropriate place) I've deliberately not update all the clients as (a) I felt it would make this PR too big and (b) each language's client may have slightly different integration requirements. I figured it could be handled on a case by case basis, as required.
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
This gets the requisite pieces in place, such that alpha and beta features can be written for the GameServer SDKs. This includes: - Moving the sdk.proto into the proto directory - Updating all the gen scripts for clients for the new sdk.proto location - creating new alpha.proto and beta.proto definitions, with an empty service stub - Integrated the new alpha and beta service stubs into the sdkserver local and sidecar implementations. - Moved all the swagger generated files under ./sdks/swagger (felt like an appropriate place) I've deliberately not update all the clients as (a) I felt it would make this PR too big and (b) each language's client may have slightly different integration requirements. I figured it could be handled on a case by case basis, as required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the requisite pieces in place, such that alpha and beta features can be written for the GameServer SDKs.
This includes:
I've deliberately not update all the clients as (a) I felt it would make this PR too big and (b) each language's client may have slightly different integration requirements. I figured it could be handled on a case by case basis, as required.