Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update developer tooling to Kubernetes 1.14 #1341

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Update developer tooling to Kubernetes 1.14 #1341

merged 2 commits into from
Feb 18, 2020

Conversation

roberthbailey
Copy link
Member

First part of #1329.

/assign @markmandel

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3532de56-d2b9-45f4-9bac-9a2bf5415bfa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1341/head:pr_1341 && git checkout pr_1341
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-7635f71

markmandel
markmandel approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did you want to update the e2e and/or prow clusters or shall I?

(Or maybe I do e2e and you do prow? Since I've no idea how prow works 😃)

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d2082b24-8928-4c8c-a6fe-9aee5726aa1e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1341/head:pr_1341 && git checkout pr_1341
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-44fd550

@pooneh-m pooneh-m merged commit e3fd883 into googleforgames:master Feb 18, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 26, 2020
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/breaking Breaking change labels Feb 26, 2020
@roberthbailey roberthbailey deleted the dev-tooling-to-1-14 branch August 24, 2020 23:02
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@roberthbailey @markmandel @ilkercelikyilmaz
Update developer tooling to Kubernetes 1.14 (googleforgames#1341)
ed34906 
Co-authored-by: Mark Mandel <mark.mandel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@markmandel markmandel

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/breaking Breaking change size/S
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@roberthbailey @agones-bot @google-oss-robot @markmandel @pooneh-m