Add shutdown duration option to Node.js simple #1413

steven-supersolid · 2020-03-14T17:29:02Z

The example code now reads the first argument if specified
If --help is passed then will exit with a help message
If a number is passed then that will be used for the shutdown duration

Converted setTimeout to use await to make code clearer
Updated watch to give more relevant information set during the test
Clear intervals correctly so these don't prevent the app from exiting
Found the app still won't exit cleanly so potentially a bug in sdk.close() (fix as separate PR)

Updated Makefile and dockerfile to pass in a parameter
Updated documentation

agones-bot · 2020-03-14T17:39:21Z

Build Failed 😱

Build Id: 6200d550-c35c-404d-9503-9563df736a67

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-14T17:47:11Z

Build Succeeded 👏

Build Id: 2cc2c5f5-db05-4272-981c-3cf6507cbcab

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-bf7f10e
image: gcr.io/agones-images/agones-sdk:1.5.0-bf7f10e
image: gcr.io/agones-images/agones-ping:1.5.0-bf7f10e
Linux C++ SDK (build): agonessdk-1.5.0-bf7f10e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-bf7f10e.zip

A preview of the website (the last 30 builds are retained):

https://bf7f10e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1413/head:pr_1413 && git checkout pr_1413
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-bf7f10e

markmandel · 2020-03-15T18:27:53Z

examples/nodejs-simple/Makefile

@@ -43,7 +43,7 @@ build:
 	cd $(root_path) && docker build -f $(project_path)/Dockerfile --tag=$(server_tag) .

 run:
-	docker run --network=host $(server_tag)
+	docker run --network=host $(server_tag) $(args)


Nice stuff - will be useful for testing #1299 👍

We should also increment the tag version in this file, so we can rebuild and push it up for people to use.

Would that be server-tag and should it be 1.5 now?

server_tag = $(REPOSITORY)/nodejs-simple-server:0.3 ➡️ server_tag = $(REPOSITORY)/nodejs-simple-server:0.4

markmandel · 2020-03-15T18:29:11Z

examples/nodejs-simple/README.md

-It will
- Setup the Agones SDK
- Call `sdk.ready()` to register that it is ready with Agones.
+It will:


Do we want to document what the command is (or the Docker run command?) should be to run this for longer than 60 seconds?

That is documented around line 120 after example debug output but perhaps clearer if I reorder?

I would also like the explicit command line argument documented.

Or is it just "120" as seconds ? Should we use a key-value pair? Like --timeout=120 ?

Would be much more explicit, and also expandable down the line. WDYT?

steven-supersolid · 2020-03-15T21:53:43Z

examples/nodejs-simple/package.json

@@ -1,6 +1,6 @@
 {
  "dependencies": {
-    "@google-cloud/agones-sdk": "1.3.0"
+    "@google-cloud/agones-sdk": "1.4.0"


Perhaps should update as part of the release @markmandel ?

I don't think this is necessary, unless there is a code change in either the SDK or the example.

Unless you can see a good reason to?

The main reason would be to keep the code sample up to date and consistent with the release. We could also change to a non-pinned dependency

But if there is no public API code change between versions, then it is up to date with the latest release 😄

markmandel · 2020-03-16T22:56:08Z

examples/nodejs-simple/README.md

+Please note that there is a max sleep time in Node.js of 2,147,483 seconds (~24 days). Values will be capped at this and negative values or zero will also be set to this.
+So to keep the server alive for a long time you could use the following:
+```
+$ make args="0" run


I would make these (no pun intended 😄 ) the full Docker run command.

That way people don't need to pull down the full example source code -- and can also replicated within their Agones install as well.

Ah sure. I was just basing this on the previous instructions. I usually run with npm start anyway.
If there's a need for both should we have both ways of running?
@roberthbailey you wrote the original README - any thoughts on this?

Ah, if it's been this way for a while, I'll be less opinionated on changing to Docker run... but it still would be nice I think?

…on. Update server version

agones-bot · 2020-03-19T21:47:38Z

Build Succeeded 👏

Build Id: 325f15de-12c4-4747-b774-66a36148bc0a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-1e395fd
image: gcr.io/agones-images/agones-sdk:1.5.0-1e395fd
image: gcr.io/agones-images/agones-ping:1.5.0-1e395fd
Linux C++ SDK (build): agonessdk-1.5.0-1e395fd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-1e395fd.zip

A preview of the website (the last 30 builds are retained):

https://1e395fd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1413/head:pr_1413 && git checkout pr_1413
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-1e395fd

agones-bot · 2020-03-19T21:50:46Z

Build Failed 😱

Build Id: dcd796ae-6334-43a8-bdfd-6e95c371f193

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-19T22:11:16Z

Build Succeeded 👏

Build Id: 1a9f601d-f449-4d44-ae67-c8ee600e4f5e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-9e2deff
image: gcr.io/agones-images/agones-sdk:1.5.0-9e2deff
image: gcr.io/agones-images/agones-ping:1.5.0-9e2deff
Linux C++ SDK (build): agonessdk-1.5.0-9e2deff-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-9e2deff.zip

A preview of the website (the last 30 builds are retained):

https://9e2deff-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1413/head:pr_1413 && git checkout pr_1413
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-9e2deff

markmandel · 2020-03-23T21:01:19Z

examples/nodejs-simple/README.md

+You can optionally specify how long the server will stay up once the basic tests are complete with the `--timeout` option.
+To do this pass arguments through, e.g. to increase the shutdown duration to 120 seconds:
+```
+$ make args="--timeout=120" run


Love this! 😄

markmandel

Ran a local test - all looks good!

google-oss-robot · 2020-03-23T21:39:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~examples/nodejs-simple/OWNERS~~ [markmandel,steven-supersolid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

markmandel · 2020-03-23T22:06:00Z

Weird, I can't update this branch to master. There is no button?

google-oss-robot · 2020-03-23T22:35:21Z

New changes are detected. LGTM label has been removed.

steven-supersolid · 2020-03-23T22:36:13Z

Wonder if it's because I merged without the button last time? But I had the button just now, so pressed it :)

markmandel · 2020-03-23T22:37:29Z

I'll wait for this to run through, and then it gets to be first in the queue 😄

agones-bot · 2020-03-23T22:53:38Z

Build Succeeded 👏

Build Id: 6e3a431f-1496-4bf1-85bf-f0114befa547

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-f4a563f
image: gcr.io/agones-images/agones-sdk:1.5.0-f4a563f
image: gcr.io/agones-images/agones-ping:1.5.0-f4a563f
Linux C++ SDK (build): agonessdk-1.5.0-f4a563f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-f4a563f.zip

A preview of the website (the last 30 builds are retained):

https://f4a563f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1413/head:pr_1413 && git checkout pr_1413
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-f4a563f

* Add optional shutdown duration. Update makefile and docs * Fix dockerfile to pass through params * Improve options handling. Fix Makefile on Windows. Update documentation. Update server version

steven-supersolid added 2 commits March 14, 2020 16:24

Add optional shutdown duration. Update makefile and docs

94fdea7

Fix dockerfile to pass through params

5407644

google-oss-robot requested review from EricFortin and roberthbailey March 14, 2020 17:29

google-oss-robot added approved size/XL labels Mar 14, 2020

Merge branch 'master' into nodejs-soak-option

bf7f10e

markmandel reviewed Mar 15, 2020

View reviewed changes

steven-supersolid commented Mar 15, 2020

View reviewed changes

roberthbailey removed the request for review from EricFortin March 16, 2020 05:54

markmandel reviewed Mar 16, 2020

View reviewed changes

markmandel added area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones labels Mar 17, 2020

steven-supersolid added 3 commits March 19, 2020 19:49

Merge remote-tracking branch 'upstream/master' into nodejs-soak-option

dfaed7d

Improve options handling. Fix Makefile on Windows. Update documentati…

1e395fd

…on. Update server version

Nit

9e2deff

markmandel reviewed Mar 23, 2020

View reviewed changes

markmandel approved these changes Mar 23, 2020

View reviewed changes

google-oss-robot assigned markmandel Mar 23, 2020

google-oss-robot added the lgtm label Mar 23, 2020

Merge branch 'master' into nodejs-soak-option

f4a563f

google-oss-robot removed the lgtm label Mar 23, 2020

markmandel merged commit 8487128 into googleforgames:master Mar 23, 2020

markmandel added this to the 1.5.0 milestone Mar 23, 2020

steven-supersolid deleted the nodejs-soak-option branch April 26, 2020 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add shutdown duration option to Node.js simple #1413

Add shutdown duration option to Node.js simple #1413

steven-supersolid commented Mar 14, 2020

agones-bot commented Mar 14, 2020

agones-bot commented Mar 14, 2020

markmandel Mar 15, 2020

steven-supersolid Mar 15, 2020

markmandel Mar 16, 2020

markmandel Mar 15, 2020

steven-supersolid Mar 15, 2020

markmandel Mar 16, 2020

steven-supersolid Mar 15, 2020

markmandel Mar 16, 2020

steven-supersolid Mar 17, 2020

markmandel Mar 17, 2020

markmandel Mar 16, 2020

steven-supersolid Mar 17, 2020

markmandel Mar 17, 2020

agones-bot commented Mar 19, 2020

agones-bot commented Mar 19, 2020

agones-bot commented Mar 19, 2020

markmandel Mar 23, 2020

markmandel left a comment

google-oss-robot commented Mar 23, 2020

markmandel commented Mar 23, 2020

google-oss-robot commented Mar 23, 2020

steven-supersolid commented Mar 23, 2020

markmandel commented Mar 23, 2020

agones-bot commented Mar 23, 2020

Add shutdown duration option to Node.js simple #1413

Add shutdown duration option to Node.js simple #1413

Conversation

steven-supersolid commented Mar 14, 2020

agones-bot commented Mar 14, 2020

agones-bot commented Mar 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Mar 19, 2020

agones-bot commented Mar 19, 2020

agones-bot commented Mar 19, 2020

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Mar 23, 2020

markmandel commented Mar 23, 2020

google-oss-robot commented Mar 23, 2020

steven-supersolid commented Mar 23, 2020

markmandel commented Mar 23, 2020

agones-bot commented Mar 23, 2020