Applied allocation test #1417

akremsa · 2020-03-16T13:45:42Z

Applied allocation test proposed by @ilkercelikyilmaz .

agones-bot · 2020-03-16T14:01:42Z

Build Failed 😱

Build Id: 10ee04ef-770c-4721-9594-9f4f62df44d9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

test/load/allocation/fleet.yaml

test/load/allocation/README.md

agones-bot · 2020-03-17T14:20:54Z

Build Failed 😱

Build Id: 42fd3243-0a48-4923-a54a-7e6c6024a14b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-17T14:21:47Z

Build Succeeded 👏

Build Id: 6ba9c45a-d1a3-4281-85f6-c19b1ea5ddaf

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-260fd4a
image: gcr.io/agones-images/agones-sdk:1.5.0-260fd4a
image: gcr.io/agones-images/agones-ping:1.5.0-260fd4a
Linux C++ SDK (build): agonessdk-1.5.0-260fd4a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-260fd4a.zip

A preview of the website (the last 30 builds are retained):

https://260fd4a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1417/head:pr_1417 && git checkout pr_1417
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-260fd4a

markmandel

Thanks for putting this in!

How does this impact the content that is in https://github.com/googleforgames/agones/tree/master/test/load now?

As part of this should we remove / move the current locust tests? @ilkercelikyilmaz do you have opinions here?

I don't know if anyone is using the locust tests?

examples/simple-udp/main.go

test/e2e/framework/framework.go

examples/simple-udp/main.go

test/load/allocation/README.md

test/load/allocation/allocationload.go

aLekSer · 2020-03-17T21:57:37Z

Run this test multiple time during a day.
This test is pretty useful to apply simple constant load to the Agones Controller.
And under this constant load there is a constant grow in consumed Memory can be seen.

Pprofed the situation and could not find the root cause. I supposed there would be a steady horizontal line.
Heap profile:
https://svgshare.com/i/JFz.svg
Not sure if there is a better way to share svgs?

akremsa · 2020-03-18T13:31:33Z

@markmandel Thanks for your comments, I've updated this PR according to them.

agones-bot · 2020-03-18T13:46:58Z

Build Failed 😱

Build Id: 40682622-0127-40a7-9408-f32875795ecd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-18T13:58:11Z

Build Failed 😱

Build Id: 042c2265-1646-4111-b0b2-57aa9b825208

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

fixes

agones-bot · 2020-03-18T14:37:05Z

Build Failed 😱

Build Id: d18a1d4e-b3b9-43bd-87eb-3df056b6136b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-18T14:48:12Z

Build Failed 😱

Build Id: 7c589b2e-de1f-41d0-be7e-3454a68d214e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-03-18T16:42:21Z

E2E test times out:

Step #22: time="2020-03-18 14:48:06.184" level=info msg="fleet simple-fleet-r5ls6 has 0/3 ready replicas"
Step #22: panic: test timed out after 10m0s
Step #22: 
Step #22: goroutine 473 [running]:
Step #22: testing.(*M).startAlarm.func1()
Step #22: 	/usr/local/go/src/testing/testing.go:1377 +0x11c
Step #22: created by time.goFunc
Step #22: 	/usr/local/go/src/time/sleep.go:168 +0x52
Step #22: 
Step #22: goroutine 1 [chan receive, 5 minutes]:
Step #22: testing.(*T).Run(0xc000488400, 0x1c7afc1, 0x1b, 0x1cfb4b8, 0x0)
Step #22: 	/usr/local/go/src/testing/testing.go:961 +0x68a
Step #22: testing.runTests.func1(0xc000488400)
Step #22: 	/usr/local/go/src/testing/testing.go:1202 +0xa7
Step #22: testing.tRunner(0xc000488400, 0xc000167c70)
Step #22: 	/usr/local/go/src/testing/testing.go:909 +0x19a
Step #22: testing.runTests(0xc0002ce760, 0x2967900, 0x32, 0x32, 0x0)
Step #22: 	/usr/local/go/src/testing/testing.go:1200 +0x522
Step #22: testing.(*M).Run(0xc0003ee080, 0x0)
Step #22: 	/usr/local/go/src/testing/testing.go:1117 +0x300
Step #22: agones.dev/agones/test/e2e.TestMain(0xc0003ee080)
Step #22: 	/go/src/agones.dev/agones/test/e2e/main_test.go:60 +0x332
Step #22: main.main()
Step #22: 	_testmain.go:140 +0x224
Step #22: 
Step #22: goroutine 19 [chan receive]:
Step #22: k8s.io/klog.(*loggingT).flushDaemon(0x2974900)
Step #22: 	/go/src/agones.dev/agones/vendor/k8s.io/klog/klog.go:975 +0xae
Step #22: created by k8s.io/klog.init.0
Step #22: 	/go/src/agones.dev/agones/vendor/k8s.io/klog/klog.go:404 +0x9b
Step #22:

markmandel

A few small nits, but otherwise this is looking good.

I'm compiling the udp-simple image now, and pushing that up, so your tests can pass 😄

test/load/allocation/README.md

test/load/allocation/fleet.yaml

test/load/allocation/runAllocation.sh

agones-bot · 2020-03-19T22:05:40Z

Build Succeeded 👏

Build Id: b87e7d6b-fa83-47e7-8a0c-2bf6c1a1cd6c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-94947ee
image: gcr.io/agones-images/agones-sdk:1.5.0-94947ee
image: gcr.io/agones-images/agones-ping:1.5.0-94947ee
Linux C++ SDK (build): agonessdk-1.5.0-94947ee-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-94947ee.zip

A preview of the website (the last 30 builds are retained):

https://94947ee-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1417/head:pr_1417 && git checkout pr_1417
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-94947ee

minor fixes

akremsa · 2020-03-20T10:10:39Z

A few small nits, but otherwise this is looking good.

I'm compiling the udp-simple image now, and pushing that up, so your tests can pass 😄

Done

agones-bot · 2020-03-20T10:28:53Z

Build Succeeded 👏

Build Id: 34ffda5a-b4dd-4fa1-b5f9-aaddb3ba2ea1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-b6f417e
image: gcr.io/agones-images/agones-sdk:1.5.0-b6f417e
image: gcr.io/agones-images/agones-ping:1.5.0-b6f417e
Linux C++ SDK (build): agonessdk-1.5.0-b6f417e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-b6f417e.zip

A preview of the website (the last 30 builds are retained):

https://b6f417e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1417/head:pr_1417 && git checkout pr_1417
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-b6f417e

markmandel

Nice!

google-oss-robot · 2020-03-23T22:12:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-03-23T22:12:43Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-03-23T22:51:18Z

Build Succeeded 👏

Build Id: 529c9f97-c3bc-4b72-a81b-b87c1db54cee

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-eb902b8
image: gcr.io/agones-images/agones-sdk:1.5.0-eb902b8
image: gcr.io/agones-images/agones-ping:1.5.0-eb902b8
Linux C++ SDK (build): agonessdk-1.5.0-eb902b8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-eb902b8.zip

A preview of the website (the last 30 builds are retained):

https://eb902b8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1417/head:pr_1417 && git checkout pr_1417
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-eb902b8

agones-bot · 2020-03-23T23:22:21Z

Build Succeeded 👏

Build Id: 20876ca1-a3df-44db-a098-d30c2d5475cb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-3f58ed6
image: gcr.io/agones-images/agones-sdk:1.5.0-3f58ed6
image: gcr.io/agones-images/agones-ping:1.5.0-3f58ed6
Linux C++ SDK (build): agonessdk-1.5.0-3f58ed6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-3f58ed6.zip

A preview of the website (the last 30 builds are retained):

https://3f58ed6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1417/head:pr_1417 && git checkout pr_1417
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-3f58ed6

* Applied allocation test Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot added the do-not-merge/work-in-progress label Mar 16, 2020

google-oss-robot requested review from EricFortin and pooneh-m March 16, 2020 13:45

google-oss-robot added the size/L label Mar 16, 2020

aLekSer reviewed Mar 17, 2020

View reviewed changes

test/load/allocation/fleet.yaml Outdated Show resolved Hide resolved

aLekSer reviewed Mar 17, 2020

View reviewed changes

test/load/allocation/README.md Outdated Show resolved Hide resolved

aLekSer reviewed Mar 17, 2020

View reviewed changes

test/load/allocation/README.md Outdated Show resolved Hide resolved

aLekSer reviewed Mar 17, 2020

View reviewed changes

test/load/allocation/README.md Outdated Show resolved Hide resolved

aLekSer reviewed Mar 17, 2020

View reviewed changes

test/load/allocation/README.md Outdated Show resolved Hide resolved

akremsa force-pushed the allocation-test branch 2 times, most recently from 260fd4a to 68e0136 Compare March 17, 2020 14:04

akremsa marked this pull request as ready for review March 17, 2020 14:05

google-oss-robot removed the do-not-merge/work-in-progress label Mar 17, 2020

markmandel reviewed Mar 17, 2020

View reviewed changes

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/feature New features for Agones labels Mar 17, 2020

akremsa force-pushed the allocation-test branch from 13bb13c to aae1f84 Compare March 18, 2020 14:15

Applied allocation test

1ee7d87

fixes

akremsa force-pushed the allocation-test branch from aae1f84 to 94947ee Compare March 18, 2020 14:19

markmandel reviewed Mar 19, 2020

View reviewed changes

test/load/allocation/README.md Outdated Show resolved Hide resolved

test/load/allocation/fleet.yaml Outdated Show resolved Hide resolved

test/load/allocation/runAllocation.sh Show resolved Hide resolved

applied review notes

b6f417e

minor fixes

akremsa force-pushed the allocation-test branch from 94947ee to b6f417e Compare March 20, 2020 10:09

markmandel approved these changes Mar 23, 2020

View reviewed changes

google-oss-robot assigned markmandel Mar 23, 2020

google-oss-robot added the lgtm label Mar 23, 2020

google-oss-robot added the approved label Mar 23, 2020

Merge branch 'master' into allocation-test

eb902b8

google-oss-robot removed the lgtm label Mar 23, 2020

Merge branch 'master' into allocation-test

3f58ed6

markmandel merged commit 6176ee0 into googleforgames:master Mar 23, 2020

markmandel added this to the 1.5.0 milestone Mar 23, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Applied allocation test (googleforgames#1417)

718f9d0

* Applied allocation test Co-authored-by: Mark Mandel <markmandel@google.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Applied allocation test #1417

Applied allocation test #1417

akremsa commented Mar 16, 2020 •

edited

Loading

agones-bot commented Mar 16, 2020

agones-bot commented Mar 17, 2020

agones-bot commented Mar 17, 2020

markmandel left a comment

aLekSer commented Mar 17, 2020 •

edited

Loading

akremsa commented Mar 18, 2020

agones-bot commented Mar 18, 2020

agones-bot commented Mar 18, 2020

agones-bot commented Mar 18, 2020

agones-bot commented Mar 18, 2020

aLekSer commented Mar 18, 2020

markmandel left a comment

agones-bot commented Mar 19, 2020

akremsa commented Mar 20, 2020

agones-bot commented Mar 20, 2020

markmandel left a comment

google-oss-robot commented Mar 23, 2020

google-oss-robot commented Mar 23, 2020

agones-bot commented Mar 23, 2020

agones-bot commented Mar 23, 2020

Applied allocation test #1417

Applied allocation test #1417

Conversation

akremsa commented Mar 16, 2020 • edited Loading

agones-bot commented Mar 16, 2020

agones-bot commented Mar 17, 2020

agones-bot commented Mar 17, 2020

markmandel left a comment

Choose a reason for hiding this comment

aLekSer commented Mar 17, 2020 • edited Loading

akremsa commented Mar 18, 2020

agones-bot commented Mar 18, 2020

agones-bot commented Mar 18, 2020

agones-bot commented Mar 18, 2020

agones-bot commented Mar 18, 2020

aLekSer commented Mar 18, 2020

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 19, 2020

akremsa commented Mar 20, 2020

agones-bot commented Mar 20, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Mar 23, 2020

google-oss-robot commented Mar 23, 2020

agones-bot commented Mar 23, 2020

agones-bot commented Mar 23, 2020

akremsa commented Mar 16, 2020 •

edited

Loading

aLekSer commented Mar 17, 2020 •

edited

Loading