-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperTuxKart Game Server that allows AI connections #1424
SuperTuxKart Game Server that allows AI connections #1424
Conversation
Build Failed 😱 Build Id: 0f34d304-7525-4800-b094-78a5d1bd2956 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 2be8b974-3a18-4a1f-b0ef-b548c47f9504 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
examples/supertuxkart/Dockerfile
Outdated
RUN rm -rf ./stk-code/.git | ||
RUN rm -rf ./stk-assets/.svn | ||
|
||
RUN cd stk-code && mkdir cmake_build && cd cmake_build && cmake .. -DBUILD_RECORDER=off \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was building my own server from source I also passed -DSERVER_ONLY=on
to cmake (which as I understand reduces the size of the binary removing stuff that is only needed to run the gui client).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, lemme take that for a spin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shaves 200M off!
git subversion | ||
|
||
RUN git clone -b allow-ai https://github.com/markmandel/stk-code.git | ||
RUN svn co https://svn.code.sf.net/p/supertuxkart/code/stk-assets stk-assets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work reliably for you? I ended up having to do this in a shell script outside of the dockerfile because docker would consistently time out pulling from subversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I had no issue at all. Weird!
Admittedly, I built it on my workstation at the office network.
examples/supertuxkart/main.go
Outdated
@@ -28,10 +28,10 @@ import ( | |||
sdk "agones.dev/agones/sdks/go" | |||
) | |||
|
|||
// logLocation is the path to the location of the SuperTuxKart log file | |||
// logLocation is the path to the location of the Super Tux Kart log file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to this file seem to be reverting #1410.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaah. Somehow that got into the thing. I will revert!
eb54709
to
cd80412
Compare
Build Succeeded 👏 Build Id: 2dc9c272-3e0e-41f2-9c67-29d589c23dc0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
RUN git clone -b allow-ai https://github.com/markmandel/stk-code.git | ||
RUN svn co https://svn.code.sf.net/p/supertuxkart/code/stk-assets stk-assets | ||
RUN rm -rf ./stk-code/.git | ||
RUN rm -rf ./stk-assets/.svn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't catch this the first time. If you don't want the source control bits, why not svn export
? It looks like you can even do it for git repositories (that are on github)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh. Good idea. Let me take this for a spin.
At the very least, I can do a --depth on the git checkout.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To allow connections from AI bots from any host required a change to the source code of Super Tux Kart. This uses the author's fork to allow the connections, and builds an image from there. Increments the Super Tux Kart image as well.
e4bf2f2
to
091baf3
Compare
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: f1187d0b-6688-4546-af17-e50e1dd7425f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
To allow connections from AI bots from any host required a change to the
source code of Super Tux Kart.
This uses the author's fork to allow the connections, and builds an
image from there.
Increments the Super Tux Kart image as well.