Terraform: Add FeatureGates into helm release #1431

aLekSer · 2020-03-26T13:12:29Z

Add new variable feature_gates to change the Agones installation parameter.

aLekSer · 2020-03-26T13:13:45Z

To be merged after #1375 as it contains part of it.

agones-bot · 2020-03-26T13:26:33Z

Build Failed 😱

Build Id: 59bcfe0d-bb6c-45a1-8e02-63611d7beced

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-03-26T18:02:04Z

The next SDK test is failing for some reason:

make[3]: Entering directory '/workspace/build'
make: *** Waiting for unfinished jobs....
make: *** [run-sdk-conformance-test-node] Error 2
includes/sdk.mk:153: recipe for target 'run-sdk-conformance-test-node' failed

aLekSer · 2020-03-27T10:26:34Z

@akremsa this way we should also add logLevel for Agones Controller. (Helm parameter)

aLekSer · 2020-03-27T10:27:29Z

build/terraform/gke/module.tf

@@ -88,6 +78,21 @@ variable "image_pull_secret" {
  default = ""
 }

+// Note: This is the number of gameserver nodes. The Agones module will automatically create an additional


This lines were moved a bit for easier diffs with examples/terraform-submodules/gke/module.tf

agones-bot · 2020-03-27T10:36:59Z

Build Succeeded 👏

Build Id: 00d27015-1ba1-4a14-953e-6943e6ca4ce7

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-6d6635a
image: gcr.io/agones-images/agones-sdk:1.5.0-6d6635a
image: gcr.io/agones-images/agones-ping:1.5.0-6d6635a
Linux C++ SDK (build): agonessdk-1.5.0-6d6635a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-6d6635a.zip

A preview of the website (the last 30 builds are retained):

https://6d6635a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1431/head:pr_1431 && git checkout pr_1431
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-6d6635a

agones-bot · 2020-03-27T10:40:51Z

Build Failed 😱

Build Id: e61d8b06-dc07-44d2-aa06-15d9821de8eb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-27T11:29:54Z

Build Succeeded 👏

Build Id: d542c272-35a0-4a5a-af2f-a90982aaa9fe

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-283d58a
image: gcr.io/agones-images/agones-sdk:1.5.0-283d58a
image: gcr.io/agones-images/agones-ping:1.5.0-283d58a
Linux C++ SDK (build): agonessdk-1.5.0-283d58a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-283d58a.zip

A preview of the website (the last 30 builds are retained):

https://283d58a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1431/head:pr_1431 && git checkout pr_1431
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-283d58a

agones-bot · 2020-04-01T14:31:25Z

Build Failed 😱

Build Id: 6edf3a49-2577-4572-98af-caf67f66c23d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-04-01T14:43:45Z

just leaving the tests fail output here:

FAIL	agones.dev/agones/pkg/gameservers	5.799s
	/usr/local/go/src/testing/testing.go:960 +0x652
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:909 +0x19a
testing.tRunner(0xc00135e100, 0xc00151e840)
	/go/src/agones.dev/agones/pkg/gameservers/controller_test.go:675 +0x980
agones.dev/agones/pkg/gameservers.TestControllerSyncGameServerCreatingState.func3(0xc00135e100)
	/go/src/agones.dev/agones/pkg/gameservers/controller.go:494 +0x5e9
agones.dev/agones/pkg/gameservers.(*Controller).syncGameServerCreatingState(0xc00129e3c0, 0xc000fcad80, 0xc001440c30, 0xc0007f8d20, 0xc0007f8c80)
	/go/src/agones.dev/agones/pkg/gameservers/controller.go:593 +0xcea
agones.dev/agones/pkg/gameservers.(*Controller).createGameServerPod(0xc00129e3c0, 0xc000fcad80, 0x1cd7fd6, 0x8, 0xc0009c3950)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
panic(0x1b40ee0, 0x2a4b0a0)
	/usr/local/go/src/testing/testing.go:874 +0x69f
testing.tRunner.func1(0xc00135e100)
goroutine 1494 [running]:

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x197fb2a]
	panic: runtime error: invalid memory address or nil pointer dereference
panic: runtime error: invalid memory address or nil pointer dereference [recovered]

agones-bot · 2020-04-01T14:57:02Z

Build Failed 😱

Build Id: d63442f1-4674-4be8-a980-f33b470dc234

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-04-01T15:01:17Z

E2E test failure this time:

time="2020-04-01 14:53:30.746" level=info msg="failing PostAllocate request" error="rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: authentication handshake failed: x509: cannot validate certificate for 35.247.4.172 because it doesn't contain any IP SANs\""
time="2020-04-01 14:53:30.701" level=info msg="fleet simple-fleet-bznsm has 3/3 ready replicas"
time="2020-04-01 14:53:28.701" level=info msg="fleet simple-fleet-bznsm has 0/3 ready replicas"
time="2020-04-01 14:53:26.714" level=info msg="fleet simple-fleet-bznsm has 0/3 ready replicas"
time="2020-04-01 14:53:24.695" level=info msg="fleet simple-fleet-bznsm has 0/3 ready replicas"
time="2020-04-01 14:53:24.667" level=info msg="waiting for fleet condition" fleet=simple-fleet-bznsm
    allocator_test.go:61: deleting pods failed: pods "agones-allocator-5c9bcbb658-rhbdl" not found
--- FAIL: TestAllocator (1.25s)

aLekSer · 2020-04-01T15:11:48Z

This version after deploying with make gcloud-terraform-install E2E tests finished successful:

time="2020-04-01 15:05:13.047" level=info msg="Finished cleanup."
ok      agones.dev/agones/test/e2e      596.004s
echo "Finishing e2e integration test!"

agones-bot · 2020-04-01T15:21:54Z

Build Succeeded 👏

Build Id: d6b26737-b3d2-4001-b46d-aae70e29abcd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-ef88f42
image: gcr.io/agones-images/agones-sdk:1.5.0-ef88f42
image: gcr.io/agones-images/agones-ping:1.5.0-ef88f42
Linux C++ SDK (build): agonessdk-1.5.0-ef88f42-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-ef88f42.zip

A preview of the website (the last 30 builds are retained):

https://ef88f42-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1431/head:pr_1431 && git checkout pr_1431
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-ef88f42

site/content/en/docs/Installation/Terraform/aks.md

Add new variable feature_gates to change the Agones installation parameter.

aLekSer · 2020-04-02T11:19:46Z

Updated the docs

agones-bot · 2020-04-02T11:33:20Z

Build Succeeded 👏

Build Id: 2ae3d719-756a-4a5b-8843-6f2bb469ebfc

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-36271ce
image: gcr.io/agones-images/agones-sdk:1.5.0-36271ce
image: gcr.io/agones-images/agones-ping:1.5.0-36271ce
Linux C++ SDK (build): agonessdk-1.5.0-36271ce-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-36271ce.zip

A preview of the website (the last 30 builds are retained):

https://36271ce-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1431/head:pr_1431 && git checkout pr_1431
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-36271ce

google-oss-robot · 2020-04-02T15:56:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-04-02T15:56:20Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-04-02T16:14:48Z

Build Succeeded 👏

Build Id: 16b338b7-6402-407c-b01f-a025440b85ec

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-562d6c8
image: gcr.io/agones-images/agones-sdk:1.5.0-562d6c8
image: gcr.io/agones-images/agones-ping:1.5.0-562d6c8
Linux C++ SDK (build): agonessdk-1.5.0-562d6c8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-562d6c8.zip

A preview of the website (the last 30 builds are retained):

https://562d6c8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1431/head:pr_1431 && git checkout pr_1431
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-562d6c8

Add new variable feature_gates to change the Agones installation parameter. Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot added the do-not-merge/work-in-progress label Mar 26, 2020

google-oss-robot requested review from markmandel and pooneh-m March 26, 2020 13:12

google-oss-robot added the size/M label Mar 26, 2020

aLekSer force-pushed the terraform/add-feature-gates branch from 9c07cb6 to 6d6635a Compare March 27, 2020 10:21

google-oss-robot added size/S and removed size/M labels Mar 27, 2020

aLekSer force-pushed the terraform/add-feature-gates branch from 6d6635a to 488b5d6 Compare March 27, 2020 10:25

google-oss-robot added size/M and removed size/S labels Mar 27, 2020

aLekSer commented Mar 27, 2020

View reviewed changes

aLekSer force-pushed the terraform/add-feature-gates branch from 488b5d6 to 283d58a Compare March 27, 2020 11:12

aLekSer force-pushed the terraform/add-feature-gates branch from 283d58a to 4d61369 Compare April 1, 2020 14:20

aLekSer marked this pull request as ready for review April 1, 2020 14:21

google-oss-robot removed the do-not-merge/work-in-progress label Apr 1, 2020

aLekSer force-pushed the terraform/add-feature-gates branch from 4d61369 to 091c9b1 Compare April 1, 2020 14:41

aLekSer force-pushed the terraform/add-feature-gates branch from 091c9b1 to ef88f42 Compare April 1, 2020 15:04

markmandel reviewed Apr 1, 2020

View reviewed changes

site/content/en/docs/Installation/Terraform/aks.md Outdated Show resolved Hide resolved

Terraform: Add FeatureGates into helm release

36271ce

Add new variable feature_gates to change the Agones installation parameter.

aLekSer force-pushed the terraform/add-feature-gates branch from ef88f42 to 36271ce Compare April 2, 2020 11:15

markmandel approved these changes Apr 2, 2020

View reviewed changes

google-oss-robot assigned markmandel Apr 2, 2020

google-oss-robot added the lgtm label Apr 2, 2020

google-oss-robot added the approved label Apr 2, 2020

Merge branch 'master' into terraform/add-feature-gates

562d6c8

google-oss-robot removed the lgtm label Apr 2, 2020

markmandel merged commit 5ef8c77 into googleforgames:master Apr 2, 2020

markmandel added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Apr 2, 2020

markmandel added this to the 1.5.0 milestone Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terraform: Add FeatureGates into helm release #1431

Terraform: Add FeatureGates into helm release #1431

aLekSer commented Mar 26, 2020

aLekSer commented Mar 26, 2020

agones-bot commented Mar 26, 2020

aLekSer commented Mar 26, 2020

aLekSer commented Mar 27, 2020 •

edited

Loading

aLekSer Mar 27, 2020 •

edited

Loading

agones-bot commented Mar 27, 2020

agones-bot commented Mar 27, 2020

agones-bot commented Mar 27, 2020

agones-bot commented Apr 1, 2020

aLekSer commented Apr 1, 2020

agones-bot commented Apr 1, 2020

aLekSer commented Apr 1, 2020

aLekSer commented Apr 1, 2020

agones-bot commented Apr 1, 2020

aLekSer commented Apr 2, 2020

agones-bot commented Apr 2, 2020

google-oss-robot commented Apr 2, 2020

google-oss-robot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

Terraform: Add FeatureGates into helm release #1431

Terraform: Add FeatureGates into helm release #1431

Conversation

aLekSer commented Mar 26, 2020

aLekSer commented Mar 26, 2020

agones-bot commented Mar 26, 2020

aLekSer commented Mar 26, 2020

aLekSer commented Mar 27, 2020 • edited Loading

aLekSer Mar 27, 2020 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Mar 27, 2020

agones-bot commented Mar 27, 2020

agones-bot commented Mar 27, 2020

agones-bot commented Apr 1, 2020

aLekSer commented Apr 1, 2020

agones-bot commented Apr 1, 2020

aLekSer commented Apr 1, 2020

aLekSer commented Apr 1, 2020

agones-bot commented Apr 1, 2020

aLekSer commented Apr 2, 2020

agones-bot commented Apr 2, 2020

google-oss-robot commented Apr 2, 2020

google-oss-robot commented Apr 2, 2020

agones-bot commented Apr 2, 2020

aLekSer commented Mar 27, 2020 •

edited

Loading

aLekSer Mar 27, 2020 •

edited

Loading